Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use 32-byte channel ids instead of short channel ids #2

Open
remyers opened this issue Sep 21, 2022 · 0 comments
Open

use 32-byte channel ids instead of short channel ids #2

remyers opened this issue Sep 21, 2022 · 0 comments

Comments

@remyers
Copy link

remyers commented Sep 21, 2022

The swap_in_request and swap_out_request messages currently pass a scid (short channel id) parameter. It would be easier to process and more consistent with existing Lightning messages if instead these messages used a 32-byte channel_id to identify the channel being requested.

Any channels used for PeerSwap should have a corresponding confirmed on-chain opening tx and thus a permanent channel_id defined. Current Lightning messages use the 32-byte channel_id to identify channels. A short_channel_id is only needed for routing, which is not relevant for PeerSwap.

In particular, Eclair watches for payments based on their channel_id and using short_channel_id in PeerSwap messages requires an unnecessary lookup or additional parameter passing. This may be true for other implementations also.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant