Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

txout nonce is inconsistently stored in coinsview #1004

Open
apoelstra opened this issue May 28, 2021 · 3 comments
Open

txout nonce is inconsistently stored in coinsview #1004

apoelstra opened this issue May 28, 2021 · 3 comments

Comments

@apoelstra
Copy link
Member

We currently do not de/serialize the txout nonce in the Coin class, meaning that after restarting the node, all nonces in the utxoset are cleared, resulting in a network where everyone has an (inconsequentially) different version of the UTXO set.

Currently the nonce is not used for anything consensus-critical, but it may be in the future --- for example, we might want input nonces covered by a future sighash version --- so this is a massive footgun.

@roconnor-blockstream
Copy link
Contributor

I recommend going through and explicitly censoring the nonce stored in any CoinsView that represents the UTXO set.

@apoelstra
Copy link
Member Author

I think we're going to just fix the serialization (after confirming that the rescan is not horribly long)

@stevenroose
Copy link
Member

Addressed by #1008.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants