Merge #1567: Prepare 23.4.0rc3

2b102c8 Update manpages (Pablo Greco)
bde2d5e Bump version to 23.4.0-rc3 (Pablo Greco)
fecf4f1 fix help man (Ruslan Kasheparov)
7647638 add 'src/rpc/blockchain.cpp:.*trim' to the KNOWN_VIOLATIONS lint checks (Ruslan Kasheparov)
8408b79 fix help man (Ruslan Kasheparov)
60a97d1 Enable ELIP203 by default in liquidv1 (Pablo Greco)
7577eb9 Enable ELIP203 by default in liquidtestnet (Pablo Greco)
72e4e1c use break-system-packages for pip (Tom Trevethan)
6515f58 change test order in feature_discount_ct to fix intermittent failure (Tom Trevethan)

Pull request description:

  Updates master to dee90f2, which fixes CI, enables ELIP 203 by default. and includes several RPC fixes.

  As usual, bump version and update manpages

ACKs for top commit:
  tomt1664:
    Tested ACK 2b102c8
  delta1:
    ACK 2b102c8; tested locally

Tree-SHA512: 8b94a7106ab6104f784c196d4b2b5997a3e80c010892fadf0e1ff49d0d1e4b04e7863dc2c562ec0ff0406b0ee7fa343b402c45fc873a47a555a7b2edcd4bfdb0

Author: delta1

configure.ac

@@ -2,7 +2,7 @@ AC_PREREQ([2.69])
 define(_CLIENT_VERSION_MAJOR, 23)
 define(_CLIENT_VERSION_MINOR, 4)
 define(_CLIENT_VERSION_BUILD, 0)
-define(_CLIENT_VERSION_RC, 2)
+define(_CLIENT_VERSION_RC, 3)
 define(_CLIENT_VERSION_IS_RELEASE, true)
 define(_COPYRIGHT_YEAR, 2026)
 define(_COPYRIGHT_HOLDERS,[The %s developers])

doc/man/elements-cli.1

@@ -1,5 +1,5 @@
 .\" DO NOT MODIFY THIS FILE!  It was generated by help2man 1.49.3.
-.TH ELEMENTS-CLI "1" "April 2026" "elements-cli v23.4.0" "User Commands"
+.TH ELEMENTS-CLI "1" "June 2026" "elements-cli v23.4.0" "User Commands"
 .SH NAME
 elements-cli \- manual page for elements-cli v23.4.0
 .SH SYNOPSIS

doc/man/elements-qt.1

@@ -1,5 +1,5 @@
 .\" DO NOT MODIFY THIS FILE!  It was generated by help2man 1.49.3.
-.TH ELEMENTS-QT "1" "April 2026" "elements-qt v23.4.0" "User Commands"
+.TH ELEMENTS-QT "1" "June 2026" "elements-qt v23.4.0" "User Commands"
 .SH NAME
 elements-qt \- manual page for elements-qt v23.4.0
 .SH SYNOPSIS
@@ -839,8 +839,9 @@ Relay and mine data carrier transactions (default: 1)
 .HP
 \fB\-datacarriersize\fR
 .IP
-Maximum size of data in data carrier transactions we relay and mine
-(default: 83)
+Relay and mine transactions whose data\-carrying raw scriptPubKeys in
+aggregate are of this size or less, allowing multiple outputs
+(default: 100000)
 .HP
 \fB\-minrelaytxfee=\fR<amt>
 .IP

doc/man/elements-tx.1

@@ -1,5 +1,5 @@
 .\" DO NOT MODIFY THIS FILE!  It was generated by help2man 1.49.3.
-.TH ELEMENTS-TX "1" "April 2026" "elements-tx v23.4.0" "User Commands"
+.TH ELEMENTS-TX "1" "June 2026" "elements-tx v23.4.0" "User Commands"
 .SH NAME
 elements-tx \- manual page for elements-tx v23.4.0
 .SH SYNOPSIS

doc/man/elements-util.1

@@ -1,5 +1,5 @@
 .\" DO NOT MODIFY THIS FILE!  It was generated by help2man 1.49.3.
-.TH ELEMENTS-UTIL "1" "April 2026" "elements-util v23.4.0" "User Commands"
+.TH ELEMENTS-UTIL "1" "June 2026" "elements-util v23.4.0" "User Commands"
 .SH NAME
 elements-util \- manual page for elements-util v23.4.0
 .SH SYNOPSIS

doc/man/elements-wallet.1

@@ -1,5 +1,5 @@
 .\" DO NOT MODIFY THIS FILE!  It was generated by help2man 1.49.3.
-.TH ELEMENTS-WALLET "1" "April 2026" "elements-wallet v23.4.0" "User Commands"
+.TH ELEMENTS-WALLET "1" "June 2026" "elements-wallet v23.4.0" "User Commands"
 .SH NAME
 elements-wallet \- manual page for elements-wallet v23.4.0
 .SH DESCRIPTION

doc/man/elementsd.1

@@ -1,5 +1,5 @@
 .\" DO NOT MODIFY THIS FILE!  It was generated by help2man 1.49.3.
-.TH ELEMENTSD "1" "April 2026" "elementsd v23.4.0" "User Commands"
+.TH ELEMENTSD "1" "June 2026" "elementsd v23.4.0" "User Commands"
 .SH NAME
 elementsd \- manual page for elementsd v23.4.0
 .SH SYNOPSIS
@@ -839,8 +839,9 @@ Relay and mine data carrier transactions (default: 1)
 .HP
 \fB\-datacarriersize\fR
 .IP
-Maximum size of data in data carrier transactions we relay and mine
-(default: 83)
+Relay and mine transactions whose data\-carrying raw scriptPubKeys in
+aggregate are of this size or less, allowing multiple outputs
+(default: 100000)
 .HP
 \fB\-minrelaytxfee=\fR<amt>
 .IP

src/chainparams.cpp

@@ -1108,6 +1108,7 @@ class CLiquidTestNetParams : public CCustomParams {
         default_signblockscript = "51210217e403ddb181872c32a0cd468c710040b2f53d8cac69f18dad07985ee37e9a7151ae";
         create_discount_ct = false;
         accept_discount_ct = true;
+        accept_unlimited_issuances = true;
         UpdateFromArgs(args);
         multi_data_permitted = true;
         SetGenesisBlock();
@@ -1220,7 +1221,7 @@ class CLiquidV1Params : public CChainParams {
 
         enforce_pak = true;
 
-        accept_unlimited_issuances = args.GetBoolArg("-acceptunlimitedissuances", false);
+        accept_unlimited_issuances = args.GetBoolArg("-acceptunlimitedissuances", true);
 
         multi_data_permitted = true;
         create_discount_ct = args.GetBoolArg("-creatediscountct", false);

src/rpc/blockchain.cpp

@@ -441,8 +441,8 @@ static RPCHelpMan getmininginfo()
                         {RPCResult::Type::NUM, "blocks", "The current block"},
                         {RPCResult::Type::NUM, "currentblockweight", /*optional=*/true, "The block weight of the last assembled block (only present if a block was ever assembled)"},
                         {RPCResult::Type::NUM, "currentblocktx", /*optional=*/true, "The number of block transactions of the last assembled block (only present if a block was ever assembled)"},
-                        {RPCResult::Type::NUM, "difficulty", "The current difficulty"},
-                        {RPCResult::Type::NUM, "networkhashps", "The network hashes per second"},
+                        {RPCResult::Type::NUM, "difficulty", /*optional=*/true, "The current difficulty"},
+                        {RPCResult::Type::NUM, "networkhashps", /*optional=*/true, "The network hashes per second"},
                         {RPCResult::Type::NUM, "pooledtx", "The size of the mempool"},
                         {RPCResult::Type::STR, "chain", "current network name (main, test, signet, regtest, liquidv1, liquidv1test, liquidtestnet)"},
                         {RPCResult::Type::STR, "warnings", "any network and blockchain warnings"},
@@ -556,11 +556,10 @@ static RPCHelpMan getblocktemplate()
             {"template_request", RPCArg::Type::OBJ, RPCArg::Default{UniValue::VOBJ}, "Format of the template",
             {
                 {"mode", RPCArg::Type::STR, /* treat as named arg */ RPCArg::Optional::OMITTED_NAMED_ARG, "This must be set to \"template\", \"proposal\" (see BIP 23), or omitted"},
-                {"capabilities", RPCArg::Type::ARR, /* treat as named arg */ RPCArg::Optional::OMITTED_NAMED_ARG, "A list of strings",
-                {
-                    {"str", RPCArg::Type::STR, RPCArg::Optional::OMITTED, "client side supported feature, 'longpoll', 'coinbasevalue', 'proposal', 'serverlist', 'workid'"},
-                }},
-                {"rules", RPCArg::Type::ARR, RPCArg::Optional::NO, "A list of strings",
+                {"longpollid", RPCArg::Type::STR, RPCArg::Optional::OMITTED_NAMED_ARG, "The longpollid from a previous template to wait for an update"},
+                {"data", RPCArg::Type::STR_HEX, RPCArg::Optional::OMITTED_NAMED_ARG, "The hex-encoded block data to validate when mode is \"proposal\" (see BIP 23)"},
+                {"maxversion", RPCArg::Type::NUM, RPCArg::Optional::OMITTED_NAMED_ARG, "Legacy maximum block version. Used only when \"rules\" is not provided"},
+                {"rules", RPCArg::Type::ARR, RPCArg::Optional::OMITTED_NAMED_ARG, "A list of strings",
                 {
                     {"segwit", RPCArg::Type::STR, RPCArg::Optional::NO, "(literal) indicates client side segwit support"},
                     {"str", RPCArg::Type::STR, RPCArg::Optional::OMITTED, "other client side supported softfork deployment"},
@@ -1556,7 +1555,7 @@ static RPCHelpMan consumecompactsketch()
                     {
                         {RPCResult::Type::STR_HEX, "blockhex", "The filled block hex. Only returns when block is final"},
                         {RPCResult::Type::STR_HEX, "block_tx_req", "The serialized structure of missing transaction indices, given to serving node"},
-                        {RPCResult::Type::STR_HEX, "found_tranasctions", "The serialized list of found transactions to be used in finalizecompactblock"},
+                        {RPCResult::Type::STR_HEX, "found_transactions", "The serialized list of found transactions to be used in finalizecompactblock"},
                     },
                 },
                 RPCExamples{
@@ -1624,8 +1623,8 @@ static RPCHelpMan consumegetblocktxn()
     return RPCHelpMan{"consumegetblocktxn",
                 "Consumes a transaction request for a compact block sketch.",
                 {
-                    {"full_block", RPCArg::Type::STR_HEX, RPCArg::Optional::NO, "Hex serialied block that corresponds to the block request `block_tx_req`."},
-                    {"block_tx_req", RPCArg::Type::STR_HEX, RPCArg::Optional::NO, "Hex serialied BlockTransactionsRequest, aka getblocktxn network message."},
+                    {"full_block", RPCArg::Type::STR_HEX, RPCArg::Optional::NO, "Hex serialized block that corresponds to the block request `block_tx_req`."},
+                    {"block_tx_req", RPCArg::Type::STR_HEX, RPCArg::Optional::NO, "Hex serialized BlockTransactionsRequest, aka getblocktxn network message."},
                 },
                 RPCResult{
                     RPCResult::Type::STR_HEX, "block_transactions", "The serialized list of found transactions aka BlockTransactions",