Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Code] Method parameter redundancy #8

Open
pavly-gerges opened this issue Aug 17, 2023 · 1 comment
Open

[Code] Method parameter redundancy #8

pavly-gerges opened this issue Aug 17, 2023 · 1 comment
Labels
core Jector core related stuff design-defect An architecture defect

Comments

@pavly-gerges
Copy link
Member

The method TaskExecutorsManager#executeMethod(Worker, Method, MethodArguments, TaskExecutorsManager) has a redundant parameter TaskExecutorsManager, this should be removed and replaced by this.
@pavly-gerges pavly-gerges added core Jector core related stuff design-correction Specifies an architecture correction PR design-defect An architecture defect and removed design-correction Specifies an architecture correction PR labels Aug 17, 2023
@pavly-gerges
Copy link
Member Author

This method is an insidious utility inside the object TaskExecutorManager and should be corrected as it violates the object-oriented programming (object methods should perform on "this" object).

@pavly-gerges pavly-gerges pinned this issue Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core Jector core related stuff design-defect An architecture defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pavly-gerges