Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit ecd7459

Browse files
committedMay 10, 2024·
Update electron version
1 parent 21c17dc commit ecd7459

File tree

3 files changed

+41
-23
lines changed

3 files changed

+41
-23
lines changed
 

‎src/ElectronNET.CLI/Commands/BuildCommand.cs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -103,13 +103,13 @@ public Task<bool> ExecuteAsync()
103103
string tempBinPath = Path.Combine(tempPath, "bin");
104104

105105
Console.WriteLine($"Build ASP.NET Core App for {platformInfo.NetCorePublishRid} under {configuration}-Configuration...");
106-
106+
107107
var dotNetPublishFlags = GetDotNetPublishFlags(parser);
108108

109109
var command =
110110
$"dotnet publish -r {platformInfo.NetCorePublishRid} -c \"{configuration}\" --output \"{tempBinPath}\" {string.Join(' ', dotNetPublishFlags.Select(kvp => $"{kvp.Key}={kvp.Value}"))} --self-contained";
111-
112-
// output the command
111+
112+
// output the command
113113
Console.ForegroundColor = ConsoleColor.Green;
114114
Console.WriteLine(command);
115115
Console.ResetColor();
@@ -198,7 +198,7 @@ public Task<bool> ExecuteAsync()
198198
: $"node build-helper.js {manifestFileName} {version}", tempPath);
199199

200200
Console.WriteLine($"Package Electron App for Platform {platformInfo.ElectronPackerPlatform}...");
201-
ProcessHelper.CmdExecute($"npx electron-builder --config=./bin/electron-builder.json --{platformInfo.ElectronPackerPlatform} --{electronArch} -c.electronVersion=23.2.0 {electronParams}", tempPath);
201+
ProcessHelper.CmdExecute($"npx electron-builder --config=./bin/electron-builder.json --{platformInfo.ElectronPackerPlatform} --{electronArch} -c.electronVersion=30.0.3 {electronParams}", tempPath);
202202

203203
Console.WriteLine("... done");
204204

@@ -252,4 +252,4 @@ private Dictionary<string, string> GetDotNetPublishFlags(SimpleCommandLineParser
252252
return dotNetPublishFlags;
253253
}
254254
}
255-
}
255+
}

‎src/ElectronNET.Host/package-lock.json

Lines changed: 35 additions & 17 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎src/ElectronNET.Host/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
},
2121
"devDependencies": {
2222
"@types/node": "^18.15.5",
23-
"electron": "^23.2.0",
23+
"electron": "^30.0.3",
2424
"tslint": "^6.1.3",
2525
"typescript": "^5.0.2"
2626
}

0 commit comments

Comments
 (0)
Please sign in to comment.