Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate _modify_eval_columns_to_ensure_version_compatibilty in RSMCompare #490

Open
aloukina opened this issue Nov 12, 2020 · 2 comments

Comments

@aloukina
Copy link
Collaborator

The Comparer class in comparer.py currently contains a class _modify_eval_columns_to_ensure_version_compatibilty to allow running RSMCompare on outputs from RSMTool < 7.0. I think it's time to deprecate this.

@Frost45 Frost45 added this to To Do in RSMTool v8.1.1 May 24, 2021
@Frost45 Frost45 moved this from To Do to In Progress in RSMTool v8.1.1 May 25, 2021
@Frost45 Frost45 removed this from In Progress in RSMTool v8.1.1 May 27, 2021
@Frost45
Copy link
Contributor

Frost45 commented May 27, 2021

It seems that in later versions of RSMTool, we want to remove support for SMD, in subgroup calculations, and only support DSM. However, SMD is used for all lists of column names (both raw and scaled). See lines 29 and 36 for example, and is only changed to DSM inside _modify_eval_columns_to_ensure_version_compatibilty(), a function we want to deprecate.

Essentially, this issue is larger than initially assumed. Will be dealt with in a later release.

@Frost45
Copy link
Contributor

Frost45 commented May 27, 2021

Also, no warnings are filtered in _modify_eval_columns_to_ensure_version_compatibilty, but filter_warnings is passed as an argument to the function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants