Skip to content

Commit 9169024

Browse files
authored
Merge pull request #476 from Edirom/issue-430
remove 'no portrait available' tooltip from work icons
2 parents ca5f837 + 0ac2d8a commit 9169024

26 files changed

+35
-28
lines changed

modules/img.xqm

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -477,8 +477,11 @@ declare
477477
return
478478
element {node-name($node)} {
479479
$node/@*[not(local-name(.) = ('src', 'title', 'alt'))],
480-
attribute title {$model('portrait')('caption')},
481-
attribute alt {$model('portrait')('caption')},
480+
if($model('portrait')('caption')) then (
481+
attribute title {$model('portrait')('caption')},
482+
attribute alt {$model('portrait')('caption')}
483+
)
484+
else attribute alt {'Preview Icon'},
482485
attribute src {$url}
483486
}
484487
else $node
@@ -491,9 +494,13 @@ declare %private function img:get-generic-portrait($model as map(*), $lang as xs
491494
else if($model('doc')//mei:term/data(@class) = 'http://d-nb.info/standards/elementset/gnd#MusicalWork') then 'musicalWork'
492495
else if(config:is-work($model('docID')) and not($model('doc')//mei:term/data(@class) = 'http://d-nb.info/standards/elementset/gnd#MusicalWork')) then 'otherWork'
493496
else $model('doc')//tei:sex/text()
497+
let $caption :=
498+
if(config:is-person($model('docID')))
499+
then 'no portrait available'
500+
else ()
494501
return
495502
map {
496-
'caption' : 'no portrait available',
503+
'caption' : $caption,
497504
'linkTarget' : (),
498505
'source' : 'Carl-Maria-von-Weber-Gesamtausgabe',
499506
'url' : function($size) {

testing/expected-results/orgs/A080005.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -277,7 +277,7 @@ <h4><a href="/exist/apps/WeGA-WebApp/de/A080005.txt">Plain Text <i class="fa fa-
277277

278278
<div class="portrait large">
279279
<div class="front">
280-
<img class="img-fluid" title="no portrait available" alt="no portrait available" src="/exist/apps/WeGA-WebApp/resources/img/icons/icon_orgs_gross.png" />
280+
<img class="img-fluid" alt="Preview Icon" src="/exist/apps/WeGA-WebApp/resources/img/icons/icon_orgs_gross.png" />
281281
</div>
282282
<div class="back colored">
283283
<h3>Bildquelle</h3>

testing/expected-results/orgs/A080033.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -277,7 +277,7 @@ <h4><a href="/exist/apps/WeGA-WebApp/de/A080033.txt">Plain Text <i class="fa fa-
277277

278278
<div class="portrait large">
279279
<div class="front">
280-
<img class="img-fluid" title="no portrait available" alt="no portrait available" src="/exist/apps/WeGA-WebApp/resources/img/icons/icon_orgs_gross.png" />
280+
<img class="img-fluid" alt="Preview Icon" src="/exist/apps/WeGA-WebApp/resources/img/icons/icon_orgs_gross.png" />
281281
</div>
282282
<div class="back colored">
283283
<h3>Bildquelle</h3>

testing/expected-results/orgs/A080043.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -277,7 +277,7 @@ <h4><a href="/exist/apps/WeGA-WebApp/de/A080043.txt">Plain Text <i class="fa fa-
277277

278278
<div class="portrait large">
279279
<div class="front">
280-
<img class="img-fluid" title="no portrait available" alt="no portrait available" src="/exist/apps/WeGA-WebApp/resources/img/icons/icon_orgs_gross.png" />
280+
<img class="img-fluid" alt="Preview Icon" src="/exist/apps/WeGA-WebApp/resources/img/icons/icon_orgs_gross.png" />
281281
</div>
282282
<div class="back colored">
283283
<h3>Bildquelle</h3>

testing/expected-results/orgs/A080052.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -277,7 +277,7 @@ <h4><a href="/exist/apps/WeGA-WebApp/de/A080052.txt">Plain Text <i class="fa fa-
277277

278278
<div class="portrait large">
279279
<div class="front">
280-
<img class="img-fluid" title="no portrait available" alt="no portrait available" src="/exist/apps/WeGA-WebApp/resources/img/icons/icon_orgs_gross.png" />
280+
<img class="img-fluid" alt="Preview Icon" src="/exist/apps/WeGA-WebApp/resources/img/icons/icon_orgs_gross.png" />
281281
</div>
282282
<div class="back colored">
283283
<h3>Bildquelle</h3>

testing/expected-results/orgs/A080059.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -277,7 +277,7 @@ <h4><a href="/exist/apps/WeGA-WebApp/de/A080059.txt">Plain Text <i class="fa fa-
277277

278278
<div class="portrait large">
279279
<div class="front">
280-
<img class="img-fluid" title="no portrait available" alt="no portrait available" src="/exist/apps/WeGA-WebApp/resources/img/icons/icon_orgs_gross.png" />
280+
<img class="img-fluid" alt="Preview Icon" src="/exist/apps/WeGA-WebApp/resources/img/icons/icon_orgs_gross.png" />
281281
</div>
282282
<div class="back colored">
283283
<h3>Bildquelle</h3>

testing/expected-results/orgs/A080114.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -277,7 +277,7 @@ <h4><a href="/exist/apps/WeGA-WebApp/de/A080114.txt">Plain Text <i class="fa fa-
277277

278278
<div class="portrait large">
279279
<div class="front">
280-
<img class="img-fluid" title="no portrait available" alt="no portrait available" src="/exist/apps/WeGA-WebApp/resources/img/icons/icon_orgs_gross.png" />
280+
<img class="img-fluid" alt="Preview Icon" src="/exist/apps/WeGA-WebApp/resources/img/icons/icon_orgs_gross.png" />
281281
</div>
282282
<div class="back colored">
283283
<h3>Bildquelle</h3>

testing/expected-results/orgs/A080124.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -277,7 +277,7 @@ <h4><a href="/exist/apps/WeGA-WebApp/de/A080124.txt">Plain Text <i class="fa fa-
277277

278278
<div class="portrait large">
279279
<div class="front">
280-
<img class="img-fluid" title="no portrait available" alt="no portrait available" src="/exist/apps/WeGA-WebApp/resources/img/icons/icon_orgs_gross.png" />
280+
<img class="img-fluid" alt="Preview Icon" src="/exist/apps/WeGA-WebApp/resources/img/icons/icon_orgs_gross.png" />
281281
</div>
282282
<div class="back colored">
283283
<h3>Bildquelle</h3>

testing/expected-results/orgs/A080126.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -277,7 +277,7 @@ <h4><a href="/exist/apps/WeGA-WebApp/de/A080126.txt">Plain Text <i class="fa fa-
277277

278278
<div class="portrait large">
279279
<div class="front">
280-
<img class="img-fluid" title="no portrait available" alt="no portrait available" src="/exist/apps/WeGA-WebApp/resources/img/icons/icon_orgs_gross.png" />
280+
<img class="img-fluid" alt="Preview Icon" src="/exist/apps/WeGA-WebApp/resources/img/icons/icon_orgs_gross.png" />
281281
</div>
282282
<div class="back colored">
283283
<h3>Bildquelle</h3>

testing/expected-results/orgs/A080135.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -277,7 +277,7 @@ <h4><a href="/exist/apps/WeGA-WebApp/de/A080135.txt">Plain Text <i class="fa fa-
277277

278278
<div class="portrait large">
279279
<div class="front">
280-
<img class="img-fluid" title="no portrait available" alt="no portrait available" src="/exist/apps/WeGA-WebApp/resources/img/icons/icon_orgs_gross.png" />
280+
<img class="img-fluid" alt="Preview Icon" src="/exist/apps/WeGA-WebApp/resources/img/icons/icon_orgs_gross.png" />
281281
</div>
282282
<div class="back colored">
283283
<h3>Bildquelle</h3>

0 commit comments

Comments
 (0)