Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ALL tweakers.net issues #34

Open
1 task done
TjeuKayim opened this issue Jan 15, 2023 · 29 comments
Open
1 task done

ALL tweakers.net issues #34

TjeuKayim opened this issue Jan 15, 2023 · 29 comments
Labels
ongoing ongoing issue

Comments

@TjeuKayim
Copy link

TjeuKayim commented Jan 15, 2023

Important note by EasyDutch authors:

uBlock Origin uses four links to update our list in their add-on/extension.

The contentURL is instantly updated after a commit, and the same applies for the first cdnURL. The other two cdnURLs are updated less.

If there is a fix you need immediately, I can update mannualy two of the three CDN's: the first cdnURL and the second jsDelivr cdnURL by going to https://www.jsdelivr.com/tools/purge.


Prerequisites / Vereisten

Describe the issue

Pages like https://tweakers.net/reviews/10768/gelikte-code-met-pyscaffold-python-projecten-ontwikkelen-als-een-pro.html are asking users to disable their adblocker.

Notes

After debugging with dev tools, I found that adding tweakers.net##+js(set, window.BannerManager, undefined) to 'My filters' in uBlock Origin bypasses the anti adblock. Though I have no experience writing these rules.

Screenshot(s)

image

@TjeuKayim TjeuKayim added the documentation Improvements or additions to documentation label Jan 15, 2023
@TjeuKayim
Copy link
Author

Sorry, I selected the wrong category, this should not have been labelled 'documentation'

@Nomes77 Nomes77 removed the documentation Improvements or additions to documentation label Jan 16, 2023
Nomes77 added a commit that referenced this issue Jan 16, 2023
better fix
@nicolaasjan
Copy link

Maybe better fix:

tweakers.net##+js(aeld, bannerLoadEvent, adblock) ?

JohnyP36 added a commit that referenced this issue Jan 16, 2023
JohnyP36 added a commit that referenced this issue Jan 16, 2023
JohnyP36 added a commit to JohnyP36/Personal-List that referenced this issue Jan 16, 2023
@TheQuickFox
Copy link

De fix werkt niet meer zo te zien.

https://tweakers.net/reviews/10866/is-matter-de-toekomst-van-smarthome-alles-wat-je-moet-weten-over-deze-standaard.html

Untitled

@JohnyP36
Copy link
Member

JohnyP36 commented Feb 16, 2023

Indeed. But there are two options now.

  1. unblock aa.tweakers.net, which is not what we want as they track you via that domain
  2. block the notice, but then you can't read the whole article.

edit:
We opened an issue at uAssets to help us solve this.

JohnyP36 added a commit that referenced this issue Feb 16, 2023
@VanHamsteren
Copy link

The issue seems to be with this script: https://tweakers.net/x/build/components.016f7b17.js

The 016f7b17 part changes every once in a while, so you need a selector like this: 'components.*.js', but if you do that, the adblock-detection is gone, but so is the post moderation and post score.

Inside that script is the adblocker detection code, so you need to block scriptlets or replace some vars. Unfortunately, this is where my knowledge stops.

@TheQuickFox
Copy link

Broken again unfortunately.

JohnyP36 added a commit that referenced this issue Mar 25, 2023
@nicolaasjan
Copy link

||tweakers.net/x/build/components.*.js$script,first-party
Article is readable, but post moderation and post score are gone...

tweakers.net##+js(aeld, , handleAdblockDetect)
Seems ineffective.

Well, they succeeded...
Had to disable uBO on that article.

@mapx-
Copy link

mapx- commented Mar 25, 2023

test first (for breakage)

tweakers.net##+js(aeld, , /^e=>.*\(e\)$/)

or if broken

@@||tweakers.net^$shide
@@||tweakers.nl^$xhr,domain=tweakers.net

@nicolaasjan
Copy link

test first (for breakage)

tweakers.net##+js(aeld, , /^e=>.*\(e\)$/)

Seems to work (didn't encounter any breakage yet).
Of course you'll have to disable the latest commit (00da790):
@@||tweakers.net/x/build/components.*.js$script,first-party

Nomes77 added a commit that referenced this issue Mar 27, 2023
@Nomes77
Copy link
Member

Nomes77 commented Mar 27, 2023

@mapx- Fixed; chosen for the second solution because of uBlockOrigin/uAssets#17294.
Reopened this issue; every issue with Tweakers can now posted here in stead of opening new issues again and again.

@Nomes77 Nomes77 reopened this Mar 27, 2023
@Nomes77 Nomes77 changed the title Anti-Adblock tweakers.net All Anti-Adblock of Tweakers Mar 27, 2023
@Nomes77 Nomes77 pinned this issue Mar 27, 2023
@Nomes77 Nomes77 changed the title All Anti-Adblock of Tweakers Issue for Anti-Adblock of Tweakers Mar 27, 2023
Nomes77 added a commit that referenced this issue Mar 27, 2023
@VanHamsteren
Copy link

I noticed that this rule was added:
||tweakers.net/x/build/components.*.js$script,first-party

If you comment out that rule, the site works again. This rule removes the adblock checker, but also removes the moderation options

@Nomes77
Copy link
Member

Nomes77 commented Mar 27, 2023

@VanHamsteren This rule is already deleted. The problem is fixed in another way.
See: e04e658

@github-actions github-actions bot added the stale label Apr 5, 2023
@Nomes77
Copy link
Member

Nomes77 commented May 8, 2023

@SnowballV I have updated two of the three CDN's (third CDN's can't be updated manually), so if you try in 30 minutes again you have now 75% chance that it will work.

@SnowballV
Copy link

OK, thanks, I'll try in half an hour.

@SnowballV
Copy link

Still the same. I'll test again, tomorrow.

@Nomes77
Copy link
Member

Nomes77 commented May 8, 2023

@JohnyP36 told me that my changes were not working, tomorrow it should (I changed a rule, ee715f0).

@SnowballV
Copy link

Thank you very much.
I purged and updated again, and now the issue is resolved.
https://tweakers.net/reviews/9892/all/zoekmachines-en-je-privacy-googelen-zonder-alles-prijs-te-geven.html
Thanks again.

@nicolaasjan
Copy link

nicolaasjan commented May 9, 2023

I have fix ee715f0 received here, but still have the detection issue, even with uBO standard configuration.
uBlock Origin 1.49.3b8 Firefox 112.0.2

screenshot1

[Edit]
Solved.
uMatrix was still blocking aa.tweakers.nl and ab.tweakers.nl.

@Chrovax
Copy link

Chrovax commented May 9, 2023

I had to refresh the page a couple of times, the anti-adblock is gone now. Thanks for the fix.

@Nomes77
Copy link
Member

Nomes77 commented May 31, 2023

Reopened this issue; every issue with Tweakers can now posted here in stead of opening new issues again and again.

@Nomes77 Nomes77 reopened this May 31, 2023
@Nomes77
Copy link
Member

Nomes77 commented Jul 26, 2023

Due to a new adblock message on only the homepage, I have broaden the last added rule.
I could find anything broken, if you find something, please report.
afbeelding

P.S. anti-adblock script can be found in https://tweakers.net/x/build/frontpage.5e29f9d5.js

Nomes77 added a commit that referenced this issue Jul 26, 2023
@Nomes77 Nomes77 changed the title Issue for Anti-Adblock of Tweakers ALL tweakers.net issues Nov 2, 2023
@issuelabeler issuelabeler bot added the duplicate This issue or pull request already exists label Nov 2, 2023
@github-actions github-actions bot closed this as completed Nov 2, 2023
@Nomes77 Nomes77 reopened this Nov 2, 2023
@EasyDutch-uBO EasyDutch-uBO deleted a comment from github-actions bot Nov 2, 2023
@Nomes77 Nomes77 removed the duplicate This issue or pull request already exists label Nov 2, 2023
@issuelabeler issuelabeler bot added the duplicate This issue or pull request already exists label Dec 30, 2023
@EasyDutch-uBO EasyDutch-uBO deleted a comment from github-actions bot Dec 30, 2023
@Nomes77 Nomes77 removed the duplicate This issue or pull request already exists label Dec 30, 2023
@Nomes77
Copy link
Member

Nomes77 commented Dec 30, 2023

Sorry, for disturbing you. My issue labeler didn't do what it should have done.

@Nomes77
Copy link
Member

Nomes77 commented Jan 10, 2024

Script for anti-adblock is now https://tweakers.net/x/build/frontpage.50f1df5c.js

@hp197
Copy link

hp197 commented Feb 23, 2024

Blocking of https://tweakers.net/x/styles/components/cookiebar/cookie_bar.fd6f85fcf49475b8103620f801820c56.css breaks the (cookie pref) model boxes:

Monosnap Gathering of Tweakers 2024-02-23 11-50-44 Monosnap Tweakers - Jouw thuis voor tech 2024-02-23 11-50-21 Monosnap Tweakers - Jouw thuis voor tech 2024-02-23 11-49-42

easylist dutch, ublock lite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ongoing ongoing issue
Development

No branches or pull requests

10 participants