Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Round all mileage to tenths place #51

Open
1 of 3 tasks
danrademacher opened this issue Jul 11, 2017 · 3 comments
Open
1 of 3 tasks

Round all mileage to tenths place #51

danrademacher opened this issue Jul 11, 2017 · 3 comments

Comments

@danrademacher
Copy link
Collaborator

danrademacher commented Jul 11, 2017

So instead of 2.33 we'd have 2.3. This would apply to the following:

  • Cue Sheet
  • Cue+Map view
  • Nearness to ECG on search for start and end.

That final one presents a small issue:
image

This would round to 0.0. In this instance, seems like we'd need to either:

  • not round or
  • set the tolerance for nearness to ECG to consider anything less than 0.05 to be on the Greenway.

The latter is preferable, but not sure if that then presents problems with actually using that point as a starting point for the router.

@clhenrick
Copy link
Collaborator

@danrademacher the tolerance for how far a searched location is to the ECG route would be a separate issue that should be opened in the ecg-map-router repo.

@clhenrick
Copy link
Collaborator

Actually there's no case for when someone is already on the Greenway, it would just say you're 0 miles from the ECG. So in that case it would be a UI update.

@danrademacher
Copy link
Collaborator Author

Let's call this lowest priority. Not worth causing other problems in the app for the sake of extra decimal place

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants