Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE/1 login signup UI #7

Merged
merged 11 commits into from
Feb 4, 2022
Merged

FEATURE/1 login signup UI #7

merged 11 commits into from
Feb 4, 2022

Conversation

OliviaYJH
Copy link
Contributor

@OliviaYJH OliviaYJH commented Feb 3, 2022

🌳 관련 이슈

close #1

🍀 PR Point

  • 로그인 뷰
  • 회원가입 뷰

<로그인 뷰>

<회원가입 뷰>

  • EditText의 글꼴은 무시하세여.. 제 폰 글꼴이라...
  • 로그인 버튼 누르면 MainActivity로 연결되도록 했습니다

@OliviaYJH OliviaYJH added junghyun🎠 정현라벨 UI labels Feb 3, 2022
@OliviaYJH OliviaYJH self-assigned this Feb 3, 2022
@OliviaYJH OliviaYJH changed the title [UI] login & signup UI FEATURE/1 login signup UI Feb 3, 2022
@OliviaYJH OliviaYJH added the Done label Feb 3, 2022
@OliviaYJH OliviaYJH linked an issue Feb 3, 2022 that may be closed by this pull request
2 tasks
visionWWW
visionWWW previously approved these changes Feb 3, 2022
<androidx.cardview.widget.CardView
android:id="@+id/card_view_signup"
android:layout_width="130dp"
android:layout_height="130dp"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

width height 고정 dp 안쓰는게 좋음!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

근데 이거는 이미지가 들어가야할 부분의 높이와 너비를 지정하는 부분이여서 따로 지정해주어야하는데 좋은 방법 있을까여..

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

정답은 아니지만.. 나는 Frame Layout 말고 Constraint Layout 사용해서 좌우 위아래 다 걸고 0dp로 만들거나, 정 안되면 가로 세로 비율을 썼거든.. 시간 괜찮다면 Constraint layout으로 convert해서 사용하는것도 좋을 듯!

Frame layout은 잘 모르겠지만.. 안드로이드 문서에서 [RelativeLayout]과 [LinearLayout]에서 아예 Constraint로 바꾸라고 대놓고 나와있어서 참고하면 좋을 것 같아!
image
image

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

그리고 정 안되면 지금은 고정dp 해놔도 괜찮을 것 같아용


<EditText
android:id="@+id/et_email_code"
android:layout_width="250dp"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여기도 고정dp 안쓰기!

<?xml version="1.0" encoding="utf-8"?>
<shape xmlns:android="http://schemas.android.com/apk/res/android"
android:shape="rectangle">
<solid
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

drawable 이름 지을때 color 부분에 green을 넣는거야! 그리고 다같이 쓸수있도록 btn말고 _ 순서대로 rectangle_green_radius_30 이렇게 쓰면 좋을거같아~

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아하아하 넵 알겠습니다

…ner-Android into feature/1-login_signup_ui

� Conflicts:
�	EarthGardener/app/src/main/AndroidManifest.xml
�	EarthGardener/app/src/main/res/values/strings.xml
@OliviaYJH OliviaYJH requested a review from visionWWW February 3, 2022 16:14
visionWWW
visionWWW previously approved these changes Feb 3, 2022
Copy link
Collaborator

@visionWWW visionWWW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고했으~~~

btnSignUpEvent()
}

private fun btnLoginEvent(){
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

안드로이드 컨벤션 Method 규칙에 화면전환하는거 Prefix navitateTo로 하면 좋을듯!

@OliviaYJH OliviaYJH requested a review from visionWWW February 3, 2022 17:59
…ner-Android into feature/1-login_signup_ui

� Conflicts:
�	EarthGardener/app/src/main/res/values/strings.xml
Copy link
Contributor

@JaesungLeee JaesungLeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니당 👍

@OliviaYJH OliviaYJH merged commit aa4993b into develop Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UI] 로그인, 회원가입 뷰
3 participants