-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEATURE/1 login signup UI #7
Conversation
<androidx.cardview.widget.CardView | ||
android:id="@+id/card_view_signup" | ||
android:layout_width="130dp" | ||
android:layout_height="130dp" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
width height 고정 dp 안쓰는게 좋음!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
근데 이거는 이미지가 들어가야할 부분의 높이와 너비를 지정하는 부분이여서 따로 지정해주어야하는데 좋은 방법 있을까여..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
그리고 정 안되면 지금은 고정dp 해놔도 괜찮을 것 같아용
|
||
<EditText | ||
android:id="@+id/et_email_code" | ||
android:layout_width="250dp" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
여기도 고정dp 안쓰기!
<?xml version="1.0" encoding="utf-8"?> | ||
<shape xmlns:android="http://schemas.android.com/apk/res/android" | ||
android:shape="rectangle"> | ||
<solid |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
drawable 이름 지을때 color 부분에 green을 넣는거야! 그리고 다같이 쓸수있도록 btn말고 _ 순서대로 rectangle_green_radius_30 이렇게 쓰면 좋을거같아~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아하아하 넵 알겠습니다
…ner-Android into feature/1-login_signup_ui � Conflicts: � EarthGardener/app/src/main/AndroidManifest.xml � EarthGardener/app/src/main/res/values/strings.xml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고했으~~~
btnSignUpEvent() | ||
} | ||
|
||
private fun btnLoginEvent(){ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
안드로이드 컨벤션 Method 규칙에 화면전환하는거 Prefix navitateTo로 하면 좋을듯!
…ner-Android into feature/1-login_signup_ui � Conflicts: � EarthGardener/app/src/main/res/values/strings.xml
This reverts commit c3bfe2b.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고하셨습니당 👍
🌳 관련 이슈
close #1
🍀 PR Point
<로그인 뷰>
<회원가입 뷰>