Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Challenger #1283

Open
4 tasks done
imagobea opened this issue Dec 1, 2022 · 0 comments
Open
4 tasks done

Challenger #1283

imagobea opened this issue Dec 1, 2022 · 0 comments
Assignees

Comments

@imagobea
Copy link
Contributor

imagobea commented Dec 1, 2022

  • Create a branch from Nightfall Node

  • The env var needed is already in place: CHALLENGER_KEY (part of environment). The challenger will only sign transactions from nightfall-optimist/src/services/challenges.mjs so we don't need to set new vars in the app state (like we did for the proposer in nightfall-optimist/src/app.mjs). Instead, read the env var directly from challenges.mjs, and get the address from the private key.

  • Where we call .encodeABI(), we need to sign and send the transaction. Please refer to the same implementations in nightfall-optimist/src/routes/proposer.mjs. Please note that you will need a new/different queue.

  • In nf3, you can remove pauseQueueChallenger and unpauseQueueChallenger. challengeEnable possibly can stay as it is. For startChallenger, you can follow the approach taken in startProposer, where the emitter was left for compatibility. Even though it does nothing. We can review these changes later.

How do we test these changes is not fully clear. We can test the endpoint with curl (passing api token). We should coordinate with the team to update tests as appropriate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants