Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename 'DeviceModelStorage' to 'DeviceModelInterface' #766

Closed
maaikez opened this issue Sep 3, 2024 · 0 comments · Fixed by #768
Closed

Rename 'DeviceModelStorage' to 'DeviceModelInterface' #766

maaikez opened this issue Sep 3, 2024 · 0 comments · Fixed by #768
Assignees
@maaikez

Comments

@maaikez
Copy link
Contributor

maaikez commented Sep 3, 2024

OCPP Version

OCPP2.0.1

Describe the problem

'DeviceModelStorage' is actually an interface. A user can use this interface as he or she wants, maybe without using any storage. So rename this to 'DeviceModelInterface'.

This is part of https://github.com/EVerest/everest-core/tree/doc/config-service/doc/config_service#next-steps-to-adjust-ocpp201-and-libocpp

Describe your solution

Rename 'DeviceModelStorage' to 'DeviceModelInterface'.

Additional context

No response
@maaikez maaikez self-assigned this Sep 3, 2024
@maaikez maaikez mentioned this issue Sep 3, 2024
Merged
2 tasks
@Pietfried Pietfried linked a pull request Sep 20, 2024 that will close this issue
Rename DeviceModelStorage to DeviceModelInterface #768
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maaikez maaikez

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename DeviceModelStorage to DeviceModelInterface EVerest/libocpp
1 participant
@maaikez