Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yachoor Updates #11

Open
Sharlikran opened this issue Dec 23, 2022 · 22 comments
Open

yachoor Updates #11

Sharlikran opened this issue Dec 23, 2022 · 22 comments

Comments

@Sharlikran
Copy link
Member

Sharlikran commented Dec 23, 2022

@yachoor Just a place to talk about updates.

@Sharlikran
Copy link
Member Author

Sharlikran commented Dec 23, 2022

image

so I'm concerned with the length of the tooltip. I would like to ask that we stop putting the quest information unless you really get it during a quest. Meaning, you have to actively be doing the quest or the book is not there. If I am not on the quest and I can get it anyway, then don't put the quest information there at all.

I will look into making an XML template or something and adding icons or whatever because that is just terrible. It is adding three lines per book.

@yachoor
Copy link

yachoor commented Dec 23, 2022

Sure!
But there's about 40 more that I couldn't get after quest,

I'm missing entries for 86 books (clues from Tomes of Tributes don't have any static location):
9 are available only during seasonal events (Jester's Festival, etc.) - I always miss those by taking quest from crown store :(
8 are from 3 dungeons (WGT, CA, GD) - I plan to run them soon, unless everybody's away for holidays, then next week :)
25 haven't found non-bookcase location yet - might take a while to get them

I think all the rest are available only during quest - will try to get them, but might take longer

@Sharlikran
Copy link
Member Author

Sharlikran commented Dec 23, 2022

I think I better take that back, add the information. However, I need some examples of books you can walk up to but you can not interact with the book if you are not on the quest. Then some books that you can only find out on the overland map after you do the quest.

@yachoor
Copy link

yachoor commented Dec 23, 2022

I think a couple book locations that are available only after quest are marked with "post-quest" comments in EideticData.lua - especially 3 entries for Mairead's Diary have both in-quest and post-quest locations.

Not sure if there are many books that show up when not on the needed quest, there's definitely one in major cities near Rogatus Cinna (but it's not added yet):
obraz
obraz
and it's also available after the quest is finished:
obraz

@Sharlikran
Copy link
Member Author

Thanks I need to research those.

@Sharlikran
Copy link
Member Author

Sharlikran commented Dec 23, 2022

I have the tooltip options set up so you can toggle it on or off.

image

image

@Sharlikran
Copy link
Member Author

Sharlikran commented Dec 23, 2022

I saw a few books where you changed the data from:

  [1] = { ["px"] = 0.6420044250, ["py"] = 0.6377716072, ["pm"] = 1986, ["d"] = true },
  [2] = { ["px"] = 0.6411860050, ["py"] = 0.6379076121, ["pm"] = 1985, ["fp"] = true, },

To a combined format

  [1] = { ["px"] = 0.6420044250, ["py"] = 0.6377716072, ["pm"] = 1986, ["d"] = true, ["zx"] = 0.6411860050, ["zy"] = 0.6379076121, ["zm"] = 1887, },

So just remember that you may have situations where you need a fake pin and the ["fp"] means it won't show in the dropdown menu from the lore library.

image

If the entry for "The Haven" was the location you didn't want to show up then use a line with ["fp"] so you only see the actual location of the book.

@yachoor
Copy link

yachoor commented Dec 23, 2022

Yeah, I use "fp" when more then 2 locations are needed - like a book in a dungeon in a city in a zone

@yachoor
Copy link

yachoor commented Dec 23, 2022

What should I do with books that have a known location, but also come from bookshelves? Right now the pins don't seem to show up if the book is marked with ["r"] = true

3 examples that have a known, non-random location entered:

  • 5624 - Origins of the Khajiiti Martial Tradition
    • just marked ["r"] = true, no pin on map
  • 6080 - Nord Cuisine: Sweets Edition
    • marked ["r"] = true, has ["m"] entry - no pin on map
  • 6232 - Investigator Vale and the Sober Nord
    • marked ["r"] = true, has ["m"] entry, has entry marked ["r"] = true - no pin on map

@Sharlikran
Copy link
Member Author

  [6080] = {
    ["c"] = true,
    ["cn"] = "Solitude Soliloquies",
    ["n"] = "Nord Cuisine: Sweets Edition",
    ["r"] = true,
    ["e"] = {
      [1] = { ["px"] = 0.6925596182, ["py"] = 1.5594300398, ["pm"] = 1747, },
    },
    ["m"] = {
      [38] = 1,
    },
  },

Do it like that. I will look into it.

@Sharlikran
Copy link
Member Author

I found a better book example to test with though.

  [6232] = {
    ["c"] = true,
    ["cn"] = "Solitude Soliloquies",
    ["n"] = "Investigator Vale and the Sober Nord",
    ["r"] = true,
    ["e"] = {
      [1] = {
        ["d"] = true,
        ["i"] = 12,
        ["py"] = 1.5297500000,
        ["r"] = true,
        ["px"] = 0.6317900000,
        ["pm"] = 1755,
      },
      [2] = {
        ["px"] = 0.3446720000,
        ["py"] = 0.3060860000,
        ["d"] = true,
        ["pm"] = 1871,
        ["zx"] = 0.3529464073, ["zy"] = 0.3030287967, ["zm"] = 1814,
      },
      [3] = { ["px"] = 0.0713760028, ["py"] = 0.6033084052, ["pm"] = 2163, ["zm"] = 2114, },
    },
    ["m"] = {
      [24] = 1,
    },
  },

(pinTag.i and pinTag.i == INTERACTION_NONE) or pinTag.l

That for some reason has nothing to do with how you interact with it. What's funny is that there is INTERACTION_NONE which is 0, and 12 is INTERACTION_BOOK, and 7 is INTERACTION_MAIL. I never understood what that was for.

["l"] = true, Which is an L in lowercase and ["i"] = 12, will be depreciated. Don't worry about them. All they do is display in some way that the book may not be where the pin was placed. Since the books are all being updated if we come across odd situations like a book that is on a table for one character but not another or a book you can read on one character but not another, we can figure out the difference at that time such as a quest requirement.

@Sharlikran
Copy link
Member Author

Sharlikran commented Dec 23, 2022

So for Investigator Vale and the Sober Nord in Briar Rock Crypts is a bookshelf not a static location.

image

image

Now if you updated that yourself and you could read a book at some point then I would need to know the exact details.

[6232] = { ["m"] = { [1814] = 1, }, }, [1871] = { { ["x"] = 0.6820194721, ["y"] = 0.7336876392, ["z"] = 1210, }, }, -- Investigator Vale and the Sober Nord, reach/briarrockruins_int01_base_0

When you open that bookshelf then you will get the following line. That is a bookshelf, not a Lorebook. If for some reason that one bookshelf in that location always has that exact book no matter what then that is different. But still just enter it as ["e"] and use /lbfake to get your position.

I will add another detailed note.

@yachoor
Copy link

yachoor commented Dec 23, 2022

I added the 3rd entry in Mandrake Manor and updated this one with dungeon entrance location, but I don't think that location was right - wiki lists it in Solitude Outlaws Refuge

@Sharlikran
Copy link
Member Author

Sharlikran commented Dec 23, 2022

Okay, see what else you can find but I'm using it to do some debugging. Then I will commit the changes. Then I'll explain the changes to that going forward you understand how Lorebooks handles the book entries.

@yachoor
Copy link

yachoor commented Dec 23, 2022

Right now I'm checking some older books with no static location too see if there truly are any that come just from bookcases - so far it seems that every book at least since Summerset has a static location.
Which means there are probably over 20 books in Galen yet to be found

@Sharlikran
Copy link
Member Author

If that is the case then it will be annoying but you would do the following

  • /lbpos and it will return Bookshelf Data but it will have the Book ID
  • /lbfake at your current location for the location of the Lorebook
  • /lbfake for all additional pins

@Sharlikran
Copy link
Member Author

Sharlikran commented Dec 23, 2022

@yachoor So originally the collection of all the books to be used for map pins would not be added if the ["q"] field was there. I don't think I ever understood how the old ["q"] and ["qm"] worked.

["q"] = Main Record: Quest ID so the UI can display the name.
["qc"] = Book Entry: Only used if the quest must be completed to display the book.

  [7416] = {
    ["c"] = true,
    ["q"] = 1234,
    ["cn"] = "Collection Name",
    ["n"] = "Book Name",
    ["e"] = {
      [1] = { ["px"] = 0.0, ["py"] = 0.0, ["pm"] = DelveMapId, },
      [2] = { ["px"] = 0.0, ["py"] = 0.0, ["pm"] = OverlandMapId, ["qc"] = true, }, -- Dev Alt Location
    }
  },

This way if ["qc"] exists then the Quest 1234 must be completed to show the book outside on the overland map. For the Delve while you are on Quest 1234 then it will show up without the requirement so you see it while on the quest.

@Sharlikran
Copy link
Member Author

Not accusing anyone but I do want to mention this to each of you because there are a few books this way. I just don't remember if there was support for the Reach in v23 or not. Plus I have been the only person entering data so far. So I don't see how this got this way.

The data from what is copy pasted into chat is all you need except you may need to rename ["pm"] to ["zm"] for fake pins.

This is incorrect

  [6447] = {
    ["c"] = true,
    ["e"] = {
      [1] = {
        ["py"] = 0.2792400000,
        ["px"] = 0.3814500000,
        ["pm"] = 1814,
        ["mn"] = 42,
        ["d"] = false,
        ["r"] = false,
        ["i"] = 12,
      },
    },
    ["n"] = "Namira's Dance",
    ["cn"] = "The Reach Reader",
  },

This is all that is needed

  [6447] = {
    ["c"] = true,
    ["e"] = {
      [1] = { ["px"] = 0.3814180048, ["py"] = 0.2793443956, ["pm"] = 1814, },
    },
    ["n"] = "Namira's Dance",
    ["cn"] = "The Reach Reader",
  },

@Sharlikran
Copy link
Member Author

Sharlikran commented Dec 24, 2022

https://github.com/ESOUIMods/LoreBooks/archive/refs/heads/master.zip

Alright, manually install that. I still have work to do to finalize it. See if the books are displayed properly.

@Sharlikran
Copy link
Member Author

Sharlikran commented Dec 25, 2022

  [5899] = {
    ["c"] = true,
    ["q"] = 6480,
    ["e"] = {
      [1] = { ["px"] = 0.7014312166, ["py"] = 1.5382663980, ["pm"] = 1809, ["zx"] = 0.7014312222, ["zy"] = 1.5382664378, ["zm"] = 1747, ["d"] = true, ["qp"] = true, },
    },
    ["n"] = "Miner's Journal",
    ["cn"] = "Solitude Soliloquies",
  },

["q"] = QuestID to be used for the name and whether or not you are actively doing the quest or whether or not you completed the quest.
["qp"] = true, Quest In Progress. Means you have to have the quest is your Journal for the book to be shown.
["qc"] = true, = Quest Completed. Means you have to have completed the quest for the book to be shown.

["i"] and ["l"] have been depreciated.

@Sharlikran
Copy link
Member Author

Sharlikran commented Dec 26, 2022

@yachoor The current syntax should be updated for the Readme.

@Sharlikran
Copy link
Member Author

Sharlikran commented Dec 28, 2022

I have Zenithar's Abbey done but I have to go to bed. I'll upload the changes tomorrow. It requires another tag to make it work that specifies the source map where you took the coordinates from. However, oddly the last book you get from the room with the Anvil doesn't work and I had to use the normalized coordinates which I was going to get rid of but I guess there will just be edge cases where it has to be used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants