Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: improve and rewrite itemfilter #989

Merged
merged 127 commits into from
Jul 24, 2024
Merged

chore: improve and rewrite itemfilter #989

merged 127 commits into from
Jul 24, 2024

Conversation

srijitcoder
Copy link
Collaborator

@srijitcoder srijitcoder commented May 27, 2024 •
edited
Loading

Implemented changes

  • Refactored/Rewrite itemfilter code as per simplifying the feature to inline-mode and stack-mode
  • Converted code from ts to js
  • Added jsdocs to all the files
  • Keyboard navigation works with tab
  • Added css-variables to customize UI
  • Removed config based property updated approach to individual attributes/properties to control item-filter's setting
  • Nested property filtering
  • External search

Screenshots/Videos

https://github.com/EOX-A/EOxElements/assets/10809211/16125b89-2b7f-4773-a06c-831e5143c338
https://github.com/EOX-A/EOxElements/assets/10809211/8e2f1772-75f3-4df1-a492-0b1f2cfc5315

Checklist before requesting a review

@srijitcoder
added basic text and multiselect checkbox to itemsfilter
88f597f
@srijitcoder
added expand component
8b69985
@srijitcoder
added expand component
b7f3772
@srijitcoder
adding inline input
5117ba1
@srijitcoder
added enable disable dropdown content on focus
9fb3d0d
@srijitcoder
added basic fuse functionality
792bfa2
@srijitcoder
conflict resolve
d2c0414
@srijitcoder
added result as new lit component
09584ff
@srijitcoder
prettier issue fix
afbcdff
@srijitcoder
fix font size result
ede192b
@srijitcoder
added dropdown with chips WIP
b79a42b
@srijitcoder
added dropdown selector with full styling
6d617b3
@srijitcoder
incorporate autocomplete with checkbox/radio selector
656ed00
@srijitcoder
added selector to filters
1b03f7f
@srijitcoder
added selector remove function
d614025
@srijitcoder
styling fixes
26fe960
@srijitcoder
added range
d0d0181
@srijitcoder
added spatial
0d592f8
@srijitcoder
individual reset button added
54aa139
@srijitcoder
reset when empty data is fileld
8bf70fa
@srijitcoder
reset all function implemented
6eff7cc
@srijitcoder
console.log removed
f2b8467
@srijitcoder
added inline mode
28b7b90
@srijitcoder
removed unwanted code
4b2ea6b
@srijitcoder
some inline mode improvement
7b8c978
@srijitcoder
lint fix
db7ddfa
@srijitcoder
some input fixes in inline mode
7483ef5
This was linked to issues Jul 18, 2024
Nested property filtering #603
Closed
Handle range and spatial filter with external search #168
Closed
Allow setting the search text placeholder default value #822
Closed
silvester-pari and others added 7 commits July 23, 2024 10:15
@silvester-pari
feat: improved list style (#1109)
ddae31a 
* feat: new list style

* chore(test): add test case for subtitles

* chore: remove unused arg

* fix(style): remove highlighting for selection filters
@silvester-pari
fix: top-level dropdown (#1125)
f121142 
* fix: show dropdown in top-layer

* chore: remove unused import
@srijitcoder
Feat: Added keys of config part of property
3826047
@srijitcoder
Feat: Updated test as per new properties
9ad15aa
@srijitcoder
Chores: Confict resolve
8c1d586
@srijitcoder
Chores: change sub description test from only to it
49c9162
@srijitcoder
chore: lint fail fix - removed unused import function
7fc5135
@silvester-pari silvester-pari merged commit c87aa33 into main Jul 24, 2024
7 checks passed
@silvester-pari silvester-pari deleted the itemfilter/feature/refactor branch July 24, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silvester-pari silvester-pari silvester-pari approved these changes

Assignees
No one assigned
Labels
itemfilter refactor
Projects
None yet
Milestone
[eox-itemfilter] v1.0.0
2 participants
@srijitcoder @silvester-pari