Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Control for viewing the loading state #911

Closed
StefanBrand opened this issue May 2, 2024 · 4 comments · Fixed by #1173
Closed

Control for viewing the loading state #911

StefanBrand opened this issue May 2, 2024 · 4 comments · Fixed by #1173
Assignees
Labels
enhancement New feature or request map

Comments

@StefanBrand
Copy link
Member

Related to #443 and having in mind the question whether all events should be bubbled up: #443 (comment)

We would like to show the user when the map is loading. I was thinking, it could be a control that shows a loading spinner between loadstart and loadend events.

Alternatively, or in addition, a loading property could be exposed that allows handling the loading state outside of the eox-map.

@StefanBrand StefanBrand added enhancement New feature or request map labels May 2, 2024
@StefanBrand StefanBrand changed the title Loading state control Control for viewing the loading state May 2, 2024
@RobertOrthofer
Copy link
Contributor

Do you want to create a loading indicator like this: https://openlayers.org/en/latest/examples/load-events.html ?
The easiest way of doing this is by emitting the loadstart-event, just like we are already emitting the loadend-Event. Would this be sufficient? I suppose we can also create a loading-Event, with a boolean value of the loading state.

@StefanBrand
Copy link
Member Author

I had a built-in control/functionality in mind, which can be toggled on by configuration. Yes, like the example, but the boilerplate lives inside eox-map.

@RobertOrthofer
Copy link
Contributor

Ah, I should read from the start. Yes, a control might be the most intuitive. Can you provide a graphic that we can use as a default spinner?

@StefanBrand
Copy link
Member Author

Nope, I don't, but I just found this neat website that lets you create spinners under a public domain license : https://loading.io/

@RobertOrthofer RobertOrthofer self-assigned this Jul 16, 2024
@silvester-pari silvester-pari added this to the [eox-map] v1.10.x milestone Jul 17, 2024
@silvester-pari silvester-pari linked a pull request Aug 5, 2024 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request map
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants