Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync back map changes to config object #908

Open
silvester-pari opened this issue May 2, 2024 · 5 comments
Open

sync back map changes to config object #908

silvester-pari opened this issue May 2, 2024 · 5 comments
Labels

Comments

@silvester-pari
Copy link
Collaborator

update the config property same as layers property (layers, view, controls)

@silvester-pari silvester-pari added enhancement New feature or request map labels May 2, 2024
@santilland
Copy link
Member

As we usually should be using an eox-map configuration i don't see this as a too important functionality. The possibility to be able to export the current OL state as config #909 i think would be enough.

@santilland
Copy link
Member

So i think i misunderstood the importance of this, as it is possible to make many changes with the layer controls, i very much think we need to make sure that map changes affect the config object, at the very least that changes done by the layer controls are reflected.
What do you think @silvester-pari and @RobertOrthofer ?

@silvester-pari
Copy link
Collaborator Author

silvester-pari commented Jul 15, 2024

This issue is specifically for the config property of the eox-map, which is a shorthand to define layers, view, and controls all at once. If you find something in e.g. the layers property that is not properly synced, could you open a dedicated issue for that?

@santilland
Copy link
Member

So the layers property should be synced? As far as i could observe if i modify for example the visibility with the layer control, this is not reflected in the layers property.
Would that be an issue for the layers control or still really an issue of the eox-map?

@RobertOrthofer
Copy link
Contributor

opacity, visibility, zIndex and custom properties should be synced back to the _jsonDefintion of each layer, appearently this is not synced back to the actual layers-property. I'm not sure if this is a regression or if this 2-way-reactivity was never fully implemented (#476)

If I remember correctly though we paused the 2-way-reactivity-approach for a clean 1-way-reactivity and the possibility to extract the current state of the element on demand

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants