-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define EPSG:4326 projection for eox-map configuration parameters #1093
Comments
This does make sense for special projections, at the moment we have some convenience logic for detecting both I feel like this change might mean a lot of changes in many parts in both code and API, and it also would mean that Maybe we can offer some additional attributes, like |
Thanks for the feedback on that, those are some good and important points. @silvester-pari what do you think? |
true, we could also allow setters, I'm slightly worried about infinite update loops if there is a conversion error between the projections, but we are already handling that issue, albeit by very simple means that might fail at some weird coordinate systems... |
Maybe a combination would be the best approach, having |
@silvester-pari @RobertOrthofer if we agree on the approach commented on my previous comment it would be great if we can consider looking into this |
i'd vote in favor of this approach, but we could also make it more versatile and allow transformations between any registered coordinate systems. Basically just exporting the vanilla ol functionalities |
I think exporting |
Sounds good to me, just a note on exporting methods; let's offer them as a dedicated export and not as an eox-map function/property; same as for |
When using different projections the center property and extent functions expect the currently used projection in the map. This makes setting and keeping track of these values somewhat difficult (when switching projections), needing to make sure externally to always re-project properties to the currently used projection.
I would propose to always expect the use of EPSG:4326 for center property, as well as for zoomExtent and related functions where extent or bbox can be set making sure the re-projection to the currently used projection is done internally.
The text was updated successfully, but these errors were encountered: