Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added delete feature for a story #108

Closed
wants to merge 29 commits into from

Conversation

kailash360
Copy link
Member

Issue Number

fixes #97

Describe the changes you've made

I have added the service to make a request of DELETE method, and also modified the apiCall function such that it can accommodate any request method. I have also added a Delete button in the page of a story tha the user can sue to delete a story.

Describe if there is any unusual behavior (Any Warning) of your code(Write NA if there isn't)
NA

Additional context (OPTIONAL)
NA

Test plan (OPTIONAL)
NA

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • The title of my pull request is a short description of the requested changes.

@kailash360
Copy link
Member Author

kailash360 commented Dec 15, 2021

@mharshita
I have created this PR in replacement of PR #104. It adds a Delete button beside the Edit button.

@kailash360 kailash360 mentioned this pull request Dec 15, 2021
5 tasks
@kaybhutani
Copy link
Member

@kailash360 i dont get it. the issue is for editing story right? have you linked the wrong issue by mistake?

Modified and Added feature to the Button in Comment Section
@kailash360
Copy link
Member Author

@kbhutani0001
As discussed here, it was observed that when a story is edited, the content changes and thus all the votes and comments may not agree with the new version of the story. So, it was suggested that a better option would be to unpublish or delete a story.

Also, I had previously made PR #104 by adding the feature to edit a story. But, as discussed in the mentioned PR, I was asked to add the Delete option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Edit Story Feature not working properly
5 participants