Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Infinite API calls #105

Open
kailash360 opened this issue Dec 11, 2021 · 4 comments · May be fixed by #112
Open

Infinite API calls #105

kailash360 opened this issue Dec 11, 2021 · 4 comments · May be fixed by #112

Comments

@kailash360
Copy link
Member

Describe the bug

Whenever a user clicks on a story to read it, the Story.js component is rendered, and this makes infinite requests to the backend.

To Reproduce

Steps to reproduce the behavior:

  1. Right click on homepage and choose Inspect
  2. Go to Networks tab
  3. Click on any story on the homepage with the inspect section open
  4. You will see infinite requests made by the client

Expected behavior

The component should make only a single request to the backend and this should be sufficient to return the required data.

Logs

Bug.mp4

Environment (please complete the following information):

  • OS: Windows 10
  • Browser: Chrome

Additional context

NIL
@kailash360
Copy link
Member Author

@cyntss
The problem is occurring due to the react-promise-tracker package. Can I fix it?

@ayushsatyam146
Copy link
Contributor

@kailash360 I am unable to reproduce this issue. I tried on the hosted link as well as by building user-story repo locally.
There are no infinte api calls.

  • OS : Ubuntu 20.04
  • Browser : Chrome and Brave

Localhost
image

Local user-story build
image

@kailash360
Copy link
Member Author

I wonder if the problem is occurring only on Windows. I faced this issue in my local server as well as in the build

@ayushsatyam146
Copy link
Contributor

Nope, I checked for windows as well, on chrome, brave, and edge.

@kailash360 kailash360 linked a pull request Jan 5, 2022 that will close this issue
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed infinite api calls in a story kailash360/user-story
2 participants
@ayushsatyam146 @kailash360