Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: AOD_550 not added to annual_cycle_zonal_mean .cfg files #852

Closed
tomvothecoder opened this issue Sep 26, 2024 · 4 comments
Closed
Labels
bug Bug fix (will increment patch version)

Comments

@tomvothecoder
Copy link
Collaborator

tomvothecoder commented Sep 26, 2024

What happened?

In PR #669, the test .cfg script includes the following variable for testing:

[#]
sets = ["annual_cycle_zonal_mean"]
case_id = "AOD_550"
variables = ["AODVIS"]
ref_name = "AOD_550"
reference_name = "AERONET-composite AOD"
test_colormap = "Oranges"
reference_colormap = "Oranges"
diff_colormap = "BrBG_r"
contour_levels = [0., 0.05, 0.1, 0.2, 0.3, 0.4, 0.5, 0.6, 0.7, 0.8, 0.9, 1.0, 1.1, 1.2]
diff_levels = [-0.5, -0.4, -0.3, -0.2, -0.1, -0.05, -0.02, 0.02, 0.05, 0.1, 0.2, 0.3, 0.4, 0.5]

I did not find this in the annual_cycle_zonal_mean_model_vs_obs.cfg file.

What did you expect to happen? Are there are possible answers you came across?

No response

Minimal Complete Verifiable Example (MVCE)

No response

Relevant log output

No response

Anything else we need to know?

No response

Environment

Latest main and cdat-migration-fy24

@tomvothecoder tomvothecoder added the bug Bug fix (will increment patch version) label Sep 26, 2024
@tomvothecoder
Copy link
Collaborator Author

@chengzhuzhang Was this variable supposed to be added? I'm running the run all script in PR #846 but it doesn't generate this file for comparison to main.

@chengzhuzhang
Copy link
Contributor

chengzhuzhang commented Sep 26, 2024

No. This entry needs to be retired. See comment here: #798 (comment)

@chengzhuzhang
Copy link
Contributor

In this case, I guess this issue can be closed?

@tomvothecoder
Copy link
Collaborator Author

Thank you for clarifying! Yes, it can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug fix (will increment patch version)
Projects
None yet
Development

No branches or pull requests

2 participants