Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove back-port of C++17 features #357

Open
bartgol opened this issue Jan 10, 2025 · 0 comments
Open

Remove back-port of C++17 features #357

bartgol opened this issue Jan 10, 2025 · 0 comments
Labels
code cleanup enhancement New feature or request

Comments

@bartgol
Copy link
Contributor

bartgol commented Jan 10, 2025

We implemented some C++17 features when we were still stuck with C++14, like ekat::any or ekat::enable_shared_from_this. Since ekat now requires C++17, all these features are available from the std library, so we should remove the hand-crafted classes. We can do a deprecation first, by doing something like

#ifndef EKAT_STD_ANY_HPP
#define EKAT_STD_ANY_HPP

#pragma warning("Warning: Including ekat_std_any.hpp is discouraged. Please avoid using ekat::any, and rely on std::any instead.")
namespace ekat {

...

}

#endif // EKAT_STD_ANY_HPP
@bartgol bartgol added enhancement New feature or request code cleanup labels Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code cleanup enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant