Skip to content

Conversation

@RobertGlobant20
Copy link
Contributor

Purpose

Updating Documentation for some LibG nodes updated recently
Several methods/nodes in LibG were updated so when LibG version was updated in Dynamo the documentation was updated but not committed to master branch, so in this fix I'm updating xml documentation for LibG nodes.

Declarations

Check these if you believe they are true

Release Notes

Updating Documentation for some LibG nodes updated recently

Reviewers

@zeusongit

FYIs

Several methods/nodes in LibG were updated so when LibG version was updated in Dynamo the documentation was updated but not committed to master branch, so in this fix I'm updating xml documentation for LibG nodes.
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates XML documentation for LibG nodes by removing documentation for deprecated or removed classes from the Analysis package. The changes align the documentation with recent LibG updates that were previously applied but not committed to the master branch.

Key Changes:

  • Removal of XML documentation for four deprecated Analysis classes and their associated members
  • Cleanup of obsolete API documentation entries

@aparajit-pratap
Copy link
Contributor

aparajit-pratap commented Nov 12, 2025

@RobertGlobant20, I thought the latest protogeometry.xml file is copied from the libg nuget package that's consumed by Dynamo. I'm not even sure we need doc/distrib/xml/en-US/ProtoGeometry.XML anymore.

@RobertGlobant20
Copy link
Contributor Author

RobertGlobant20 commented Nov 13, 2025

@RobertGlobant20, I thought the latest protogeometry.xml file is copied from the libg nuget package that's consumed by Dynamo. I'm not even sure we need doc/distrib/xml/en-US/ProtoGeometry.XML anymore.

@aparajit-pratap yes, this xml file is coming from the libg nuget package not sure if is needed or not but there is a Copy Task in the DynamoCore.csproj (existing from long time ago) for that specific file, please @zeusongit confirm that the xml file is not needed so we can submit another task for updating the DynamoCore.csproj or should I do it as part of this PR?
Thanks

@zeusongit
Copy link
Contributor

@RobertGlobant20, I thought the latest protogeometry.xml file is copied from the libg nuget package that's consumed by Dynamo. I'm not even sure we need doc/distrib/xml/en-US/ProtoGeometry.XML anymore.

@aparajit-pratap yes, this xml file is coming from the libg nuget package not sure if is needed or not but there is a Copy Task in the DynamoCore.csproj (existing from long time ago) for that specific file, please @zeusongit confirm that the xml file is not needed so we can submit another task for updating the DynamoCore.csproj or should I do it as part of this PR? Thanks

Lets do it in this PR, but please confirm before moving forward if we depend on this file or not. If not, we can remove the Copy task for this file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants