Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

demo/bug: lr_demo #59

Open
sameerashahh opened this issue Jun 17, 2024 · 1 comment
Open

demo/bug: lr_demo #59

sameerashahh opened this issue Jun 17, 2024 · 1 comment
Labels
good first issue / mild Good for newcomers

Comments

@sameerashahh
Copy link
Collaborator

Describe the bug
ImportError: cannot import name 'plot_old' from 'dynadojo.utils.kuramoto'

To Reproduce
Steps to reproduce the behavior:

  1. Go to demos/algorithms/lr_demo.ipynb
  2. Run each cell
  3. Error occurs in the second sell.

Expected behavior
A correct plot function should be imported from src/dynadojo/utils/kuramoto.py
@carynbear carynbear added the good first issue / mild Good for newcomers label Jun 17, 2024
@lmclane04
Copy link
Collaborator

Delete plot_old. Program only uses plot() so we only need to import plot from dynadojo.utils.kuramoto.
After this, the following errors also occur in a few places.

  • plot() got an unexpected keyword argument 'legend_labels'
  • resolve by changing 'legend_labels' to 'labels'
  • plot() got multiple values for argument 'max_oscillators'
  • resolve by deleting "timesteps", which is not a parameter in plot().

lmclane04 pushed a commit to lmclane04/dynadojo that referenced this issue Jul 2, 2024
@lmclane23
Fix import error on lr_demo
9e4dafb 
- delete plot_old in second cell
 - change 'legend_labels' to 'labels' iin cell 4 and 7 to resolve  unexpected keyword argument error.
- delete 'timesteps' parameter in cell 4, 6, and 7 to resolve plot() got multiple values for argument 'max_oscillators' error.

Resolves DynaDojo#59
@lmclane04 lmclane04 mentioned this issue Jul 2, 2024
Closed
lmclane04 pushed a commit to lmclane04/dynadojo that referenced this issue Jul 3, 2024
@lmclane23
fix: fixes DynaDojo#59 import error on lr_demo DynaDojo#85
8f415b6 
- delete plot_old in second cell
- change 'legend_labels' to 'labels' iin cell 4 and 7 to resolve unexpected keyword argument error.
- delete 'timesteps' parameter in cell 4, 6, and 7 to resolve plot() got multiple values for argument 'max_oscillators' error.

Resolves DynaDojo#59
@lmclane04 lmclane04 mentioned this issue Jul 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue / mild Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: fixes #59 import error on lr_demo lmclane04/dynadojo
3 participants
@carynbear @sameerashahh @lmclane04