Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve: migrate from tensorflow to pytorch #42

Open
carynbear opened this issue May 12, 2024 · 2 comments · Fixed by #49
Open

improve: migrate from tensorflow to pytorch #42

carynbear opened this issue May 12, 2024 · 2 comments · Fixed by #49
Labels
enhancement New feature or request good first issue / mild Good for newcomers

Comments

@carynbear
Copy link
Collaborator

carynbear commented May 12, 2024

Tensorflow is used in:

  • src/dynadojo/systems/fbsnn_pde/bsb.py
  • src/dynadojo/systems/fbsnn_pde/hjb.py
  • src/dynadojo/systems/utils/fbsnn.py
  • src/dynadojo/baselines/dnn.py

Rather than use multiple ML frameworks, we want to simplify and use either torch or tensorflow. I think torch is the better option because of PyTorch's dynamic computation graph, ease of debugging, and its increasing popularity in the research community.

Once refactored, please test and make sure the demos are working with similar results. And then remove tensorflow packages from pyproject.toml and installation from Docker.

Rebuild and publish Docker images accordingly.

@carynbear carynbear added the enhancement New feature or request label May 12, 2024
@carynbear
Copy link
Collaborator Author

carynbear commented Jul 2, 2024

src/dynadojo/baselines/dnn.py --> refactored to use torch.
tensorflow version is now in src/dynadojo/baselines/dnn_keras.py.

@carynbear carynbear linked a pull request Jul 2, 2024 that will close this issue
@carynbear
Copy link
Collaborator Author

carynbear commented Jul 2, 2024

  1. Let's just remove these systems and algorithms from the code and documentation entirely.
  • src/dynadojo/systems/fbsnn_pde/bsb.py
  • src/dynadojo/systems/fbsnn_pde/hjb.py
  • src/dynadojo/systems/utils/fbsnn.py
  • src/dynadojo/baselines/dnn_keras.py
  1. Remove tensorflow from the pyproject.toml

@carynbear will need to handle docker rebuilding, ignore that for now.

@carynbear carynbear changed the title Migrate from tensorflow to pytorch improve: migrate from tensorflow to pytorch Jul 2, 2024
@carynbear carynbear added the good first issue / mild Good for newcomers label Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue / mild Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant