Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

listAllObjectsV2 method internally uses listObjects instead of listObjectsV2 #2

Open
tomekit opened this issue Nov 24, 2022 · 0 comments

Comments

@tomekit
Copy link

tomekit commented Nov 24, 2022

I am not exactly sure if that's intended, but I believe this is some sort of mistake.

Basically, the listAllObjectsV2 method name as well its description: "...This uses ListObjectsV2 in the S3 API..." implies that it's using the V2 API, but in fact it's using the old ListObjects internally.
I was also confused what's actually the difference between: listAllObjectsV2 and listObjectsV2, if both by default return all objects (they paginate over the results).

I am not complaining, don't get me wrong, this project is amazing and way more powerful then the AWS Amplify for Flutter.
It's just I've thought I will highlight some inconsistencies.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant