chore(kms/auth-eth): clean up Prek failures inherited from foundry branch

The Prek CI workflow runs `prek run --from-ref base --to-ref head` across
the full PR diff, so pre-existing whitespace and shellcheck issues in the
foundry branch's anvil helper scripts (added by the original migration
contributor) were blocking the PR even though they predated this session.

Auto-fixers (trailing-whitespace, end-of-file-fixer) cleaned up 10 files
with no behavioral impact.

Shellcheck warnings, all in kms/auth-eth/scripts/:
- cleanup.sh: dropped unused RED/YELLOW color variables; added
  `# shellcheck source=/dev/null` for the dynamic source; switched
  `! -z` → `-n`; quoted `$ANVIL_PID`.
- run-tests.sh: source directive; quoted `$ANVIL_PID`, `$SERVER_PID`,
  `$i`, `$ETH_RPC_URL`; switched `! -z` → `-n`.
- setup-local-chain.sh: quoted `$i`.
- test-all.sh: added source directive for `../.env.test`.

Verification: prek run --from-ref origin/master --to-ref HEAD passes all
hooks. forge test --ffi (46/46) and Slither (0 findings) still clean.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: h4x3rotab

kms/auth-eth/.env.example

@@ -18,4 +18,4 @@ KMS_CONTRACT_ADDR=0x0000000000000000000000000000000000000000
 
 # For testing with testnet:
 # ETH_RPC_URL=https://rpc.sepolia.org
-# KMS_CONTRACT_ADDR=<your_deployed_contract_address>
+# KMS_CONTRACT_ADDR=<your_deployed_contract_address>

kms/auth-eth/README.md

@@ -155,4 +155,4 @@ forge snapshot
 anvil
 ```
 
-Documentation: https://book.getfoundry.sh/
+Documentation: https://book.getfoundry.sh/

kms/auth-eth/TESTING.md

@@ -20,7 +20,7 @@ npm run test:all           # Complete: Anvil + Deploy + API tests + Cleanup
 
 This automatically:
 1. Starts Anvil node
-2. Deploys contracts 
+2. Deploys contracts
 3. Starts API server
 4. Tests all endpoints
 5. Cleans up
@@ -44,4 +44,4 @@ curl -X POST http://127.0.0.1:8000/bootAuth/app \
 ### Cleanup
 ```bash
 npm run test:cleanup       # Stop all test processes
-```
+```

kms/auth-eth/script/README.md

@@ -324,12 +324,12 @@ contract MyCustomScript is BaseScript {
     function run() external {
         // Read parameters
         uint256 value = vm.envUint("MY_VALUE");
-        
+
         // Execute transaction
         vm.startBroadcast();
         kms.someFunction(value);
         vm.stopBroadcast();
-        
+
         // Log result
         console.log("Executed with value:", value);
     }
@@ -341,4 +341,4 @@ contract MyCustomScript is BaseScript {
 - Use `--dry-run` to simulate without broadcasting
 - Add `-vvvv` for detailed trace output
 - Check gas usage with `--gas-report`
-- Use `.env` files to manage environment variables
+- Use `.env` files to manage environment variables

kms/auth-eth/scripts/README.md

@@ -122,4 +122,3 @@ The scripts generate the following log files:
 - Node.js and npm
 - Foundry (forge, anvil)
 - All npm dependencies installed (`npm install`)
-

kms/auth-eth/scripts/cleanup.sh

@@ -11,9 +11,7 @@ PROJECT_ROOT="$(cd "$SCRIPT_DIR/.." && pwd)"
 ENV_FILE="$PROJECT_ROOT/.env.test"
 
 # Colors for output
-RED='\033[0;31m'
 GREEN='\033[0;32m'
-YELLOW='\033[1;33m'
 NC='\033[0m'
 
 echo "🧹 Cleaning up test environment..."
@@ -25,12 +23,13 @@ pkill -f "node dist/main.js" || true
 
 # Load environment if exists
 if [ -f "$ENV_FILE" ]; then
+    # shellcheck source=/dev/null
     source "$ENV_FILE"
-    
+
     # Kill Anvil if PID is set
-    if [ ! -z "$ANVIL_PID" ]; then
+    if [ -n "$ANVIL_PID" ]; then
         echo "Stopping Anvil (PID: $ANVIL_PID)..."
-        kill $ANVIL_PID 2>/dev/null || true
+        kill "$ANVIL_PID" 2>/dev/null || true
     fi
 fi
 
@@ -46,4 +45,4 @@ rm -f "$PROJECT_ROOT/deploy.log"
 rm -f "$PROJECT_ROOT/server-test.log"
 rm -f "$PROJECT_ROOT/integration-test.js"
 
-echo -e "${GREEN}✅ Cleanup complete!${NC}"
+echo -e "${GREEN}✅ Cleanup complete!${NC}"

kms/auth-eth/scripts/run-tests.sh

@@ -29,6 +29,7 @@ if [ ! -f "$ENV_FILE" ]; then
 fi
 
 # Load environment variables
+# shellcheck source=/dev/null
 source "$ENV_FILE"
 
 # Export for child processes
@@ -37,7 +38,7 @@ export KMS_CONTRACT_ADDR
 export APP_IMPLEMENTATION
 
 # Check if Anvil is running
-if ! kill -0 $ANVIL_PID 2>/dev/null; then
+if ! kill -0 "$ANVIL_PID" 2>/dev/null; then
     echo -e "${RED}❌ Error: Anvil is not running (PID: $ANVIL_PID)${NC}"
     echo -e "${YELLOW}Please run ./scripts/setup-local-chain.sh first${NC}"
     exit 1
@@ -59,8 +60,8 @@ npm run build
 cleanup() {
     echo ""
     echo "🧹 Cleaning up..."
-    if [ ! -z "$SERVER_PID" ]; then
-        kill $SERVER_PID 2>/dev/null || true
+    if [ -n "$SERVER_PID" ]; then
+        kill "$SERVER_PID" 2>/dev/null || true
     fi
 }
 trap cleanup EXIT
@@ -77,7 +78,7 @@ for i in {1..30}; do
         echo -e "${GREEN}✅ API server is ready!${NC}"
         break
     fi
-    if [ $i -eq 30 ]; then
+    if [ "$i" -eq 30 ]; then
         echo -e "${RED}❌ API server failed to start within 30 seconds${NC}"
         cat "$PROJECT_ROOT/server-test.log"
         exit 1
@@ -102,13 +103,13 @@ async function runIntegrationTests() {
     const baseUrl = 'http://127.0.0.1:8000';
     const rpcUrl = process.env.ETH_RPC_URL;
     const kmsAddress = process.env.KMS_CONTRACT_ADDR;
-    
+
     console.log('Testing against:');
     console.log('  API URL:', baseUrl);
     console.log('  RPC URL:', rpcUrl);
     console.log('  KMS Contract:', kmsAddress);
     console.log('');
-    
+
     const testData = {
         tcbStatus: 'UpToDate',
         advisoryIds: [],
@@ -120,14 +121,14 @@ async function runIntegrationTests() {
         instanceId: '0x3456789012345678901234567890123456789012',
         deviceId: '0x' + 'ef12ef12ef12ef12'.repeat(4)
     };
-    
+
     const tests = [
         {
             name: 'Health Check',
             run: async () => {
                 const res = await fetch(baseUrl + '/');
                 const data = await res.json();
-                return { 
+                return {
                     passed: res.status === 200 && data.kmsContractAddr === kmsAddress,
                     details: `Status: ${res.status}, Contract: ${data.kmsContractAddr}`
                 };
@@ -191,10 +192,10 @@ async function runIntegrationTests() {
             }
         }
     ];
-    
+
     let passed = 0;
     let failed = 0;
-    
+
     for (const test of tests) {
         try {
             const result = await test.run();
@@ -213,10 +214,10 @@ async function runIntegrationTests() {
             failed++;
         }
     }
-    
+
     console.log('');
     console.log(`Summary: ${passed} passed, ${failed} failed`);
-    
+
     return failed === 0;
 }
 
@@ -237,7 +238,7 @@ rm -f "$PROJECT_ROOT/integration-test.js"
 # Run Foundry tests
 echo ""
 echo -e "${BLUE}🔨 Running Foundry tests...${NC}"
-ETHERSCAN_API_KEY=dummy forge test --ffi --rpc-url $ETH_RPC_URL
+ETHERSCAN_API_KEY=dummy forge test --ffi --rpc-url "$ETH_RPC_URL"
 FOUNDRY_RESULT=$?
 
 # Summary
@@ -261,4 +262,4 @@ if [ $INTEGRATION_RESULT -ne 0 ] || [ $FOUNDRY_RESULT -ne 0 ]; then
 fi
 
 echo ""
-echo -e "${GREEN}✅ All tests passed!${NC}"
+echo -e "${GREEN}✅ All tests passed!${NC}"

kms/auth-eth/scripts/setup-local-chain.sh

@@ -53,7 +53,7 @@ for i in {1..30}; do
         echo -e "${GREEN}✅ Anvil is ready!${NC}"
         break
     fi
-    if [ $i -eq 30 ]; then
+    if [ "$i" -eq 30 ]; then
         echo -e "${RED}❌ Anvil failed to start within 30 seconds${NC}"
         cat "$PROJECT_ROOT/anvil.log"
         exit 1
@@ -125,4 +125,4 @@ echo "   Anvil: $PROJECT_ROOT/anvil.log"
 echo "   Deploy: $PROJECT_ROOT/deploy.log"
 echo ""
 echo -e "${YELLOW}ℹ️  To stop Anvil: kill $ANVIL_PID${NC}"
-echo -e "${YELLOW}ℹ️  To run tests: ./scripts/run-tests.sh${NC}"
+echo -e "${YELLOW}ℹ️  To run tests: ./scripts/run-tests.sh${NC}"

kms/auth-eth/scripts/test-all.sh

@@ -28,10 +28,11 @@ echo "Step 2: Running tests..."
 "$SCRIPT_DIR/run-tests.sh" "$@"
 
 # Load env to get PID
+# shellcheck source=/dev/null
 source "$SCRIPT_DIR/../.env.test"
 
 echo ""
 echo -e "${GREEN}✅ Complete test suite finished!${NC}"
 echo ""
 echo -e "${YELLOW}ℹ️  To stop the local chain: kill $ANVIL_PID${NC}"
-echo -e "${YELLOW}ℹ️  To run tests again: ./scripts/run-tests.sh${NC}"
+echo -e "${YELLOW}ℹ️  To run tests again: ./scripts/run-tests.sh${NC}"

kms/auth-eth/src/ethereum.ts

@@ -8,7 +8,7 @@ import { BootInfo, BootResponse } from './types';
 // Minimal ABI for DstackKms contract
 const DSTACK_KMS_ABI = [
   "function isAppAllowed((address appId,bytes32 composeHash,address instanceId,bytes32 deviceId,bytes32 mrAggregated,bytes32 mrSystem,bytes32 osImageHash,string tcbStatus,string[] advisoryIds) bootInfo) view returns (bool, string)",
-  "function isKmsAllowed((address appId,bytes32 composeHash,address instanceId,bytes32 deviceId,bytes32 mrAggregated,bytes32 mrSystem,bytes32 osImageHash,string tcbStatus,string[] advisoryIds) bootInfo) view returns (bool, string)", 
+  "function isKmsAllowed((address appId,bytes32 composeHash,address instanceId,bytes32 deviceId,bytes32 mrAggregated,bytes32 mrSystem,bytes32 osImageHash,string tcbStatus,string[] advisoryIds) bootInfo) view returns (bool, string)",
   "function gatewayAppId() view returns (string)",
   "function appImplementation() view returns (address)"
 ];