Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fake Leave Should Trigger Scoreboard Criteria #44

Open
AphoticGoblin opened this issue Jul 3, 2024 · 6 comments
Open

Fake Leave Should Trigger Scoreboard Criteria #44

AphoticGoblin opened this issue Jul 3, 2024 · 6 comments
Labels
enhancement New feature or request question Further information is requested

Comments

@AphoticGoblin
Copy link

Fake leaves do not trigger scoreboard criteria, making it so that any datapacks which detect leaves through this method will clearly reveal that the leave is a fake.

@DrexHD
Copy link
Owner

DrexHD commented Jul 3, 2024

Which scoreboard criteria is used for detecting leaving?
Edit: Looking through the code, I assume you are referring to minecraft.custom:minecraft.leave_game

@AphoticGoblin
Copy link
Author

Correct

@DrexHD
Copy link
Owner

DrexHD commented Jul 6, 2024

Can you explain your setup. Because as far as I was aware, it is mainly useful to detect joins. Because the player is no longer present when the stat is increased and therefor can no longer be selected through entity selectors -> no detection 🤔.

@AphoticGoblin
Copy link
Author

I have a datapack that plays a sound when the scoreboard increases for any player and also a datapack that removes a tag from a player when the scoreboard increases for them.

@DrexHD
Copy link
Owner

DrexHD commented Jul 16, 2024

I still don't understand. If I have two command blocks like this running every tick, which are always loaded.

  1. execute as @a[scores={leave=1..}] run say test
  2. scoreboard players remove @a[scores={leave=1..}] leave 1
    and a scoreboard /scoreboard objectives add leave minecraft.custom:minecraft.leave_game, test will only be sent to the chat when I join, not when I leave.

@DrexHD DrexHD added enhancement New feature or request question Further information is requested labels Sep 24, 2024
@AphoticGoblin
Copy link
Author

I dunno, the datapack's called Vanilla Refresh if you want to check out how it works.
It plays a sound both when a player joins and a player leaves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants