Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG/AC-Link] - Search Functionality doesn't work properly #111

Open
TheSCREWEDSoftware opened this issue Nov 7, 2024 · 2 comments
Open
Labels

Comments

@TheSCREWEDSoftware
Copy link

Issue: azerothcore/wiki#1019

Describe the bug

Go to any page in the wiki.

Example: game_tele

And try searching majority of wiki content as example Item Template or even more precise item_template

You will get all the results but none that matches to your search.

image

To reproduce

  • Go to any page in the wiki.

Example: game_tele

  • And try searching majority of wiki content as example Item Template or even more precise item_template

  • You will get all the results but none that matches to your search.

Expected behavior

To partially get my result.

Screenshots

image

Desktop

Windows 10 64bit, Chrome 130 64bit

Smartphone

N/A

Additional context

No response

@Yehonal
Copy link
Member

Yehonal commented Nov 8, 2024

This wiki offers 3 different kinds of search mechanisms:

  • GitHub (just the normal GitHub search that looks for the MD files)
  • google ((the google search console that uses google, but it's not real-time)
  • pre-compiled javascript (this is the current one)

This is a static wiki hence we can't use a server to search.

That said, I tried this query (game_tele):

image

As you can see the page is in the list but down the list. In your case it's probably also part of the results but since the list is limited, it doesn't show up.

We can do 2 things:

  1. having a list that can be scrolled
  2. trying to order by page title first and then the content

WDYT?

@Yehonal Yehonal added the bug label Nov 8, 2024
@TheSCREWEDSoftware
Copy link
Author

I think it would be a good change yea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants