CHOLMOD: horzcat, check if A and B dtype mismatch

DrTimothyAldenDavis · DrTimothyAldenDavis · commit 41166cee176e · 2023-11-29T04:30:20.000-06:00
diff --git a/CHOLMOD/MatrixOps/cholmod_horzcat.c b/CHOLMOD/MatrixOps/cholmod_horzcat.c
@@ -89,7 +89,7 @@ cholmod_sparse *CHOLMOD(horzcat)    // return C = [A B]
         ERROR (CHOLMOD_INVALID, "A and B must have same # rows") ;
         return (NULL) ;
     }
-    if (mode != 0 && (A->xtype != B->xtype || A->dtype != A->dtype))
+    if (mode != 0 && (A->xtype != B->xtype || A->dtype != B->dtype))
     {
         // A and B must have the same xtype and dtype if mode is 0
         ERROR (CHOLMOD_INVALID, "A and B must have same xtype and dtype") ;

Original file line number	Diff line number	Diff line change
`@@ -89,7 +89,7 @@ cholmod_sparse *CHOLMOD(horzcat) // return C = [A B]`
`89`	`89`	`ERROR (CHOLMOD_INVALID, "A and B must have same # rows") ;`
`90`	`90`	`return (NULL) ;`
`91`	`91`	`}`
`92`		`- if (mode != 0 && (A->xtype != B->xtype \|\| A->dtype != A->dtype))`
	`92`	`+ if (mode != 0 && (A->xtype != B->xtype \|\| A->dtype != B->dtype))`
`93`	`93`	`{`
`94`	`94`	`// A and B must have the same xtype and dtype if mode is 0`
`95`	`95`	`ERROR (CHOLMOD_INVALID, "A and B must have same xtype and dtype") ;`