Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ledge Grab Movement Issue #28

Open
McAchi opened this issue Aug 15, 2024 · 4 comments
Open

Ledge Grab Movement Issue #28

McAchi opened this issue Aug 15, 2024 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@McAchi
Copy link

McAchi commented Aug 15, 2024

Issue only applies when Collision Fixes is ON.
( Issue is both on 30 and 60 FPS ).

Issue was found in Noki Bay, with the tight ledges that Mario has to grab onto to move around high up on the walls.

Some spots on the ledges seem to act as one-way walls, where Mario gets pushed from one side, and blocked from the other.
The spots are consistent ( always the same ).
My theory is the Collision Fixes don't take the weird world geometry into account, therefore wacky behaviour.

( Unrelated, but is it possible for pre-rendered cutscenes to fill the whole screen in 16:9, since that's how they were rendered? )

Thank you, and great mod!

@JoshuaMKW JoshuaMKW self-assigned this Aug 15, 2024
@JoshuaMKW JoshuaMKW added the bug Something isn't working label Aug 15, 2024
@JoshuaMKW
Copy link
Member

I'll have to check that out. As for the THPs, this likely isn't going to happen due to how the cutscenes were rendered in 16:9 (baked black borders), and the general logistical issue of convincing the THP player to crop out pixels on the top and bottom without things freaking out.

@McAchi
Copy link
Author

McAchi commented Aug 15, 2024

I knew them black borders were to blame, but that's not a big deal.
Hope that finding out what makes those ledges wack isn't too difficult, wish you luck!
Thank you!

@JoshuaMKW
Copy link
Member

Ledges are now fixed but I'll wait to close until it makes its way to a release.

@McAchi
Copy link
Author

McAchi commented Aug 21, 2024

Alright, good to know.
Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants