Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bearer authentication #61

Merged
merged 4 commits into from
Nov 23, 2021
Merged

Add bearer authentication #61

merged 4 commits into from
Nov 23, 2021

Conversation

vsouz4
Copy link
Collaborator

@vsouz4 vsouz4 commented Nov 19, 2021

No description provided.

@vsouz4 vsouz4 linked an issue Nov 19, 2021 that may be closed by this pull request
Copy link
Collaborator

@JasonBenett JasonBenett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My main concern with the current implementation is that we will have to specify the security scheme for every requests when the most common usage will probably be to have a unique security scheme defined for the whole API. And so, not defined per endpoint and so, not defined per Request but at ApiClient level most probably.

But maybe should be addressed in a separated PR to support both approaches.

CHANGELOG.md Show resolved Hide resolved
@vsouz4
Copy link
Collaborator Author

vsouz4 commented Nov 23, 2021

My main concern with the current implementation is that we will have to specify the security scheme for every requests when the most common usage will probably be to have a unique security scheme defined for the whole API. And so, not defined per endpoint and so, not defined per Request but at ApiClient level most probably.

But maybe should be addressed in a separated PR to support both approaches.

you're right, I've focused on this operation-level security because that's what we needed right now, but we must still add support for global security requirements, we can track that via other issues when we need it, also other types of authentication can be added/tracked the same way

@vsouz4 vsouz4 requested a review from JasonBenett November 23, 2021 10:35
@vsouz4 vsouz4 merged commit 29e9dd8 into master Nov 23, 2021
@vsouz4 vsouz4 deleted the add-bearer-authentication branch November 23, 2021 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handling OpenApi securitySchemes for Authentication concerns
2 participants