Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nest extension hook to nav menus #29

Open
briandominick opened this issue May 24, 2021 · 0 comments
Open

Add nest extension hook to nav menus #29

briandominick opened this issue May 24, 2021 · 0 comments
Labels
enhancement New feature or request Liquid Incorporates Liquid templating

Comments

@briandominick
Copy link
Contributor

I have not really thought this one through, but it came up as I was documenting the nav menus, so I wanted to pin it on the board.

I believe all of the manually configurable menus (site nav in the header, subject nav in the left sidebar, and company nav in the footer) could accommodate additional nesting.

I have run a quick test on Navgoco (subject nav), and it can handle at least another tier of nesting. I am just not sure I want to support that.

The Bootstrap-driven site nav can definitely handle more nesting. See https://bootstrap-menu.com/detail-multilevel.html. This can look rather nice, but is it ever necessary? I haven't been asked to implement anything that hardcore for a site menu, but it wouldn't be hard.

But I might have to put my foot down before trying this in the footer. There is plenty of room down there, though stream-of-consciousness I guess I can fathom wanting to have lots of links in the footer but keeping it sparse at first glance from a design perspective.

Anyway, the issue is placing an extension hook at the deepest point of nesting, in case you want to continue the iteration in your own templates.

@briandominick briandominick added enhancement New feature or request Liquid Incorporates Liquid templating JavaScript Involves some JS struggles and removed JavaScript Involves some JS struggles labels May 24, 2021
@briandominick briandominick changed the title Add nest to nav menus Add nest extension hook to nav menus May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Liquid Incorporates Liquid templating
Projects
None yet
Development

No branches or pull requests

1 participant