Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifications when paiement cancelled by the patch #33

Open
Djaytan opened this issue Jan 8, 2023 · 0 comments
Open

Notifications when paiement cancelled by the patch #33

Djaytan opened this issue Jan 8, 2023 · 0 comments
Labels
good first issue Good for newcomers p:medium Medium priority t:feature New feature or request

Comments

@Djaytan
Copy link
Owner

Djaytan commented Jan 8, 2023

As a player, I shall see in some way that the paiement has been cancelled by the patch plugin.

A good way could be sending a message through the action bar. It's discreet and consistent with default config of JobsReborn paiments notifications.

The message could be the following one:

  • On non-ephemeral tag retrieved: &cPaiement cancelled: breaking block placed by a player.
  • On ephemeral tag retrieved stilling active: &cPaiement cancelled: too quick place and break manipulation.

It is recommended to use Kyori and MiniMessage libraries for the implementation.

i18n is out-of-scope and may be overkill for just two messages.

The configuration aspect is out-of-scope: this is managed by the issue #34.

@Djaytan Djaytan converted this from a draft issue Jan 8, 2023
@Djaytan Djaytan added t:feature New feature or request good first issue Good for newcomers labels Jan 8, 2023
@Djaytan Djaytan added this to the Backlog milestone Jan 8, 2023
@Djaytan Djaytan removed this from the Backlog milestone Feb 22, 2023
@Djaytan Djaytan added the p:low Low priority label Feb 26, 2023
@Djaytan Djaytan added p:medium Medium priority and removed p:low Low priority labels Nov 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers p:medium Medium priority t:feature New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant