Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn the parameter loanId as an indexed parameter in the DepositCollateral event #391

Open
jjmr007 opened this issue Nov 6, 2021 · 0 comments · Fixed by #394
Open

Turn the parameter loanId as an indexed parameter in the DepositCollateral event #391

jjmr007 opened this issue Nov 6, 2021 · 0 comments · Fixed by #394
Assignees

Comments

@jjmr007
Copy link
Contributor

jjmr007 commented Nov 6, 2021

Rationale

It simplifies the searching of all collateral added to a specific loan position

Change

from this:
event DepositCollateral(bytes32 loanId, uint256 depositAmount, uint256 rate);

to this:

event DepositCollateral(bytes32 indexed loanId, uint256 depositAmount, uint256 rate);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants