Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment dev variable inconsistency #133

Open
bestchai opened this issue May 26, 2020 · 0 comments
Open

Deployment dev variable inconsistency #133

bestchai opened this issue May 26, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@bestchai
Copy link
Member

bestchai commented May 26, 2020

The "dev" variable is set to "true" in dev.js and "false" in deployed.js

However, when an example log is clicked, in shiviz.js, there is the following statement:
(dev ? "https://api.github.com/repos/bestchai/shiviz-logs/contents/" : "/shiviz/log/")

This works right now but going by how "dev" is set, it should be loading the log from "/shiviz/log/" during deployment but it's actually fetching from github. The situation is reversed for fetching motifs.json in searchBar.js even though the statement is the same. That is, during deployment, it loads the file from "/shiviz/log" instead of from github.

A temporary fix is in b9af7ad where we try the local path first and when it fails, we fetch the file from github

[Issue created by pattypcw: 2015-08-19]

@bestchai bestchai added the bug Something isn't working label May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant