Clip StatusRowView to prevent media from hiding swipe action buttons #2107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a status contains multiple images, they overlap with the swipe action buttons, hiding them.
Fixes #2106
This PR clips the
StatusRowViewand switches the horizontal inset for horizontal padding.At first, I only added the clipping.
Unfortunately, due to the list inset, this made the content not go edge to edge, defeating what I guess was the desired effect of the feature. (See alternative solution for the result)
This is the reason why I also had to replace the list horizontal inset for the horizontal content padding.
Before
After
Alternative solution