Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore SlideFlow interface #97

Open
Leengit opened this issue Jan 26, 2023 · 0 comments
Open

Explore SlideFlow interface #97

Leengit opened this issue Jan 26, 2023 · 0 comments

Comments

@Leengit
Copy link
Collaborator

Leengit commented Jan 26, 2023

SlideFlow's interface is different from HistomicStream's. We should decide whether we want to add functionality to HistomicsStream to support a similar interface.

My notes: The SlideFlow interface for dataset management is different from HistomicsStream, in part, because SlideFlow uses configuration files. The user supplies the name of the configuration files (or a directory with several files) instead of supplying the actual parameters. Without changing the HistomicsStream interface all that much, we could support configuration files. That is, where we are currently specifying

my_study = {"version": "version-1"}
my_slides = my_study["slides"] = {}
my_slide0 = my_slides["Slide_0"] = {}
my_slide0["filename"] = wsi_path
my_slide0["slide_name"] = "TCGA-AN-A0G0-01Z-00-DX1"
my_slide0["slide_group"] = "Group 3"
my_slide0["number_pixel_rows_for_chunk"] = 2048
my_slide0["number_pixel_columns_for_chunk"] = 2048

we could also support something like

my_study = {"version": "version-1"}
my_slides = my_study["slides"] = {}
my_slides["Slide_0"] = {"configuration_file": "my_slide0_configuration.json"}

Or we could also change HistomicsStream more drastically so that one doesn't even realize that there is a hierarchy of dictionaries. For example, with SlideFlow a top-level configuration file can include the names of lower-level configuration files. We could then read the whole configuration -- high-level, study-wide parameters and individual slides' parameters -- with something like

my_study = hs.new_study("my_study_configuration.json")
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant