Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checking XML signature sometimes fails #9

Open
binaryape opened this issue Jan 5, 2023 · 1 comment
Open

Checking XML signature sometimes fails #9

binaryape opened this issue Jan 5, 2023 · 1 comment
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@binaryape
Copy link
Contributor

binaryape commented Jan 5, 2023

Running benchmarks for Smee revealed an unusual bug: about 3 in 7 runs to check the signatures of large metadata aggregate files will fail.

Failure seems more likely if loading XML files from a Mac /var/folders temp directory.

Loading the same files to simply validate the XML never fails, so it isn't an issue with loading the data correctly.

It appears to be an issue inside the xmldsig library, but possibly only on M/Arm Macs.

It also might not happen for small (MDQ-style) metadata files.

@binaryape binaryape added bug Something isn't working help wanted Extra attention is needed labels Jan 5, 2023
@binaryape
Copy link
Contributor Author

When I run for i in {1..10}; do mdqt check ukfederation-metadata.xml --verbose --verify-with ./ukfederation.pem ; done 10/10 pass

When I run for i in {1..10}; do mdqt check /var/folders/2f/852dg3vs5q9_h79x9d6m_0jc0000gn/T/smeevf-1672860083-38895-c51v73 --verbose --verify-with ./ukfederation.pem ; done a few fails each time, maybe 8/10 pass

It's a copy of the same file, just in a temp dir.

When I run a Benchee test loadtesting mdqt as a backend, in a user home directory, some will sometimes fail, so there's still a failure chance when not in a temp directory, it just seems higher in the temp directory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant