Remove direct access to neoscore.background_brush
#114
Labels
enhancement
New feature or request
good first issue
Good for newcomers
help wanted
Extra attention is needed
neoscore.background_brush
is a global variable that users are expected to set usingneoscore.set_background_brush
, but this creates a very easy error for users understandably attempting to change the background brush by simply sayingneoscore.background_brush = Brush(...)
.We should update this to make the global variable hidden by naming it
neoscore._background_brush
, and then making access to it go through a new functionneoscore.get_background_brush() -> Brush
.This is a breaking change, but I think worthwhile. The background brush is very rarely read by users anyway.
The text was updated successfully, but these errors were encountered: