Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do occur-check in unification instead of in subst-accumulation #215

Open
MxmUrw opened this issue Mar 1, 2022 · 3 comments
Open

Do occur-check in unification instead of in subst-accumulation #215

MxmUrw opened this issue Mar 1, 2022 · 3 comments
Assignees
Labels
error handling Error messages are useless question Further information is requested
Milestone

Comments

@MxmUrw
Copy link
Member

MxmUrw commented Mar 1, 2022

In #214 we took the easy way, but we should be able to have better error messages if we do this in unification itself, before adding the substitution.

Though this depends on how our error reporting is implemented.

@MxmUrw
Copy link
Member Author

MxmUrw commented Mar 18, 2022

We need to evaluate how criticial it is to do this and add further error information. For this we need a test case which recreates this issue.

@MxmUrw MxmUrw added question Further information is requested error handling Error messages are useless labels Mar 18, 2022
@MxmUrw
Copy link
Member Author

MxmUrw commented Mar 23, 2022

Maybe we should pass a message when doing addSub, then it is fine to still do the check in substitution.

@MxmUrw MxmUrw self-assigned this Mar 28, 2022
@MxmUrw
Copy link
Member Author

MxmUrw commented Apr 12, 2022

As this is a pretty rare error, we do not add a message for now. This issue can become relevant again when there is an actual example where this error occurs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
error handling Error messages are useless question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant