Skip to content

Commit 04894c3

Browse files
authored
Fix/doris 3187 disable remote control playpause (#446)
* fix:UTV-4088 tvOS | VOD title missing on Video Player Page * fix: UTV-4096-tvOS | RTL | Seek Speed Tooltip appears in English * Revert "fix: UTV-4096-tvOS | RTL | Seek Speed Tooltip appears in English" This reverts commit 0d4db40. * fix: bump RNDV fix DORIS-3187 [TVOS] | Animated Hero | disable remote control to toggle play/pause state
1 parent a00dc0d commit 04894c3

File tree

5 files changed

+8
-4
lines changed

5 files changed

+8
-4
lines changed

ios/JSProps/JSProps.swift

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ class JSProps {
2424
var hideAdUiElements: Dynamic<Bool> = Dynamic(false)
2525
var isWhyThisAdIconEnabled: Dynamic<Bool> = Dynamic(false)
2626
var locale: Dynamic<String?> = Dynamic(nil)
27+
var isPlayPauseEnabled: Dynamic<Bool> = Dynamic(true)
2728
}
2829

2930
class Dynamic<T> {

ios/Video/PlayerViewProxy.swift

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -232,7 +232,7 @@ class PlayerViewProxy {
232232
drm: rndvJSDrm,
233233
progressUpdateInterval: sourceValue.progressUpdateInterval ?? 6,
234234
type: sourceValue.type,
235-
title: sourceValue.title ?? "",
235+
title: sourceValue.title ?? sourceValue.nowPlaying?.title ?? "",
236236
description: jsProps.metadata.value?.description, //tvos new
237237
live: sourceValue.live,
238238
partialVideoInformation: jsPartialVideoInformation,
@@ -285,7 +285,8 @@ class PlayerViewProxy {
285285
seekForwardInterval: seekForwardInterval,
286286
seekBackwardInterval: seekBackwardInterval,
287287
hideAdUiElements: jsProps.hideAdUiElements.value,
288-
isWhyThisAdIconEnabled: jsProps.isWhyThisAdIconEnabled.value)
288+
isWhyThisAdIconEnabled: jsProps.isWhyThisAdIconEnabled.value,
289+
isPlayPauseEnabled: jsProps.isPlayPauseEnabled.value)
289290

290291
if let rndvJSSource = rndvJSSource {
291292
let jsVideoData = RNDReactNativeDiceVideo.JSVideoData(source: rndvJSSource, config: rndvJSVideoDataConfig)

ios/Video/RCTVideoManager.m

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ @interface RCT_EXTERN_MODULE(RCTVideoManager, RCTViewManager)
3333
RCT_EXPORT_VIEW_PROPERTY(hideAdUiElements, BOOL);
3434
RCT_EXPORT_VIEW_PROPERTY(isWhyThisAdIconEnabled, BOOL);
3535
RCT_EXPORT_VIEW_PROPERTY(locale, NSString);
36+
RCT_EXPORT_VIEW_PROPERTY(isPlayPauseEnabled, BOOL);
3637

3738
/* Should support: onLoadStart, onLoad, and onError to stay consistent with Image */
3839
RCT_EXPORT_VIEW_PROPERTY(onVideoLoadStart, RCTBubblingEventBlock);

package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "react-native-video",
3-
"version": "7.11.2",
3+
"version": "7.11.3",
44
"dorisAndroidVersion": "5.1.11",
55
"messagingAndroidVersion": "1.1.0",
66
"description": "A <Video /> element for react-native",
@@ -21,7 +21,7 @@
2121
"eslint-plugin-react": "3.16.1"
2222
},
2323
"dependencies": {
24-
"@dicetechnology/react-native-dice-video": "git+ssh://[email protected]/DiceTechnology/react-native-dice-video.git#7.1.7",
24+
"@dicetechnology/react-native-dice-video": "git+ssh://[email protected]/DiceTechnology/react-native-dice-video.git#7.1.8",
2525
"@dicetechnology/dice-unity": "^2.26.3",
2626
"keymirror": "0.1.1",
2727
"prop-types": "^15.5.10"

types/player.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,4 +45,5 @@ export interface IVideoPlayer extends IVideoPlayerCallbacks, ViewProps {
4545
selectedAudioTrack?: any // TODO
4646
width?: number;
4747
subtitleHorizontalPadding?: number;
48+
isPlayPauseEnabled?: boolean;
4849
}

0 commit comments

Comments
 (0)