refactor: Adjust Helm push #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DiamondJoseph
commented
Nov 4, 2025
Comment on lines
+36
to
+38
| push: ${{ github.event_name == 'push' && github.ref_type == 'tag' }} | ||
| tags: ${{ steps.meta.outputs.tags }} | ||
| labels: ${{ steps.meta.outputs.labels }} |
Contributor
Author
There was a problem hiding this comment.
Run docker/build-push-action@v6
with:
push: false
tags: ghcr.io/diamondlightsource/glazed:latest
From this PR (i.e. non-tag/release run) we would no longer publish on non-tagged commits but still build the container to ensure the Dockerfile is still valid.
The PCT has a stage to run the container and make sure it starts also? Should we have an issue for a command that returns immediately (e.g. glazed --version) to check that the config is preset and the executable is available?
Contributor
There was a problem hiding this comment.
As in an issue to add this as a build step? glazed --version already exists as a command (cargo run -- --version)
Contributor
Author
There was a problem hiding this comment.
Added the build step, see the CI run for this PR
Run docker run --rm test_tag --version
glazed 0.1.0
DiamondJoseph
commented
Nov 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making a PR so I can publish from a fork under my own namespace and ensure this behaves how I expect