Skip to content

Conversation

@olliesilvester
Copy link
Collaborator

Will supersede #1473

Draft until DiamondLightSource/mx-bluesky#1336 is done

Instructions to reviewer on how to test:

  1. Do thing x
  2. Confirm thing y happens

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@DominicOram
Copy link
Contributor

May supersede #1473, @olliesilvester to get these into one PR and if it's a simple one let's just get them merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants