Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add make_signature and verify_signature to Sspi trait. #343

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add make_signature and verify_signature to Sspi trait. #343

wants to merge 3 commits into from
+430 −25

Conversation

AvivNaaman
Copy link

resolves #338

@AvivNaaman
Add make_signature and verify_signature to Sspi trait.
64d2a71 
Implement for NTLM.
Missing docs & tests.
TheBestTvarynka
TheBestTvarynka reviewed Jan 10, 2025
View reviewed changes
Copy link
Collaborator

@TheBestTvarynka TheBestTvarynka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,
Thank you for your contribution! I reviewed the code and left a few comments. Overall, your code is good 👍

src/negotiate.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
src/ntlm/mod.rs Outdated Show resolved Hide resolved
src/ntlm/mod.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
@AvivNaaman
Documentation, UnsupportedFunction erros, and some default implementa…
9ac42d3 
…tions.

Error message formatting.
Use a generic u32 flags parameter for *_signature functions.
@AvivNaaman
Copy link
Author

@TheBestTvarynka What tests are you suggesting to add to the new functions?
Most of the current tests for encryption/decryption provide a descent validation to the signature functions (indirectly -- I suppose we'd like to add some tests for those functions specifically.
Should I copy the existing tests and modify them (to perform, for example, make_signature instead of encrypt_message, and test the output), write a whole other set of tests, or modify the existing tests to check both flows somehow?

@TheBestTvarynka
Copy link
Collaborator

Should I copy the existing tests and modify them (to perform, for example, make_signature instead of encrypt_message, and test the output), write a whole other set of tests, or modify the existing tests to check both flows somehow?

The signing and verification overlap with encryption and decryption a lot, so I think there is no point in testing corner cases.
I suggest you add one signing-verification test to show how it works. This will be enough.

@AvivNaaman
Copy link
Author

@TheBestTvarynka I added a test for make_signature validated properly by verify_signature, and invalid signature declined by verify_signature.
As far as I know, the PR is ready to merged. Let me know if any more changes are necessary to complete it.
Thanks!

TheBestTvarynka
TheBestTvarynka approved these changes Jan 17, 2025
View reviewed changes
Copy link
Collaborator

@TheBestTvarynka TheBestTvarynka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good code 👍

Please, format the code (cargo +nightly fmt --all) and fix clippy warnings (cargo clippy --all-features --all-targets)

@TheBestTvarynka TheBestTvarynka marked this pull request as ready for review January 17, 2025 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheBestTvarynka TheBestTvarynka TheBestTvarynka approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Supporting no-encryption NTLM message signing & GSS MIC calculation
2 participants
@AvivNaaman @TheBestTvarynka