Allow uploading files with invalid characters (Resolve #454) (#455)

Author: MikhailTymchukDX

AjaxControlToolkit.Tests/AjaxFileUploadTests.cs

@@ -10,6 +10,7 @@ public class AjaxFileUploadTests {
         string _tempFolder;
         const string testBody = "------WebKitFormBoundaryCqenIHPHe1ZTCr0d\r\nContent-Disposition: form-data; name=\"act-file-data\"; filename=\"zero.jpg\"\r\nContent-Type: image/jpeg\r\n\r\n\r\n------WebKitFormBoundaryCqenIHPHe1ZTCr0d--\r\n";
         const string testQuery = "filename=aaa.jpg&fileId=E63F2078-D5C7-66FA-5CAD-02C169149BD5";
+        const string testQueryFilenameInvalidChars = "filename=a:a*a.jpg&fileId=E63F2078-D5C7-66FA-5CAD-02C169149BD5"; 
         const string testQueryNoExtension = "filename=aaa&fileId=E63F2078-D5C7-66FA-5CAD-02C169149BD5";
         const string testContentType = "multipart/form-data; boundary=----WebKitFormBoundaryCqenIHPHe1ZTCr0d";
 
@@ -88,5 +89,13 @@ public void DoNotUseBufferlessInputStream() {
             var context = new HttpContext(request);
             Assert.DoesNotThrow(() => AjaxFileUploadHelper.Process(context));
         }
+
+        [Test]
+        public void InvalidFilenameChars() {
+            var request = new WorkerRequest(testBody, testQueryFilenameInvalidChars, testContentType);
+            var context = new HttpContext(request);
+            AjaxFileUploadHelper.Process(context);
+            Assert.True(File.Exists(Path.Combine(_tempFolder, "E63F2078-D5C7-66FA-5CAD-02C169149BD5", "a-a-a.jpg.tmp")));
+        }
     }
 }

AjaxControlToolkit/AjaxFileUpload/AjaxFileUploadHelper.cs

@@ -201,6 +201,9 @@ static void CreateTempFilePathFolder(string tmpFilePath) {
 
         private static string GetTempFilePath(string fileId, string fileName) {
             var tempFolder = AjaxFileUpload.GetTempFolder(fileId);
+            foreach (var invalidChar in Path.GetInvalidFileNameChars()) {
+                fileName = fileName.Replace(invalidChar, '-');
+            }
             return Path.Combine(tempFolder, fileName) + Constants.UploadTempFileExtension;
         }
     }