Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing definition of GPS_RX and GPS_TX #23

Open
jayAitch256 opened this issue Apr 26, 2021 · 0 comments
Open

Confusing definition of GPS_RX and GPS_TX #23

jayAitch256 opened this issue Apr 26, 2021 · 0 comments

Comments

@jayAitch256
Copy link

I'm trying to adapt this sketch for a custom ESP32 based board with an external GPS and a different pinmap. After a while I realized that GPS_RX and GPS_TX (gps.h) are defined in a pretty unusual way here.

The pin GPS_RX means the TX pin of the ESP here (wired to RX of the GPS). GPS_TX is the RX pin of the ESP (wired to TX of the GPS).

I understand that this won't really matter if you just use the T-Beam, but for others who are planning to reuse the code for other boards, this notice might be helpful since it is not the "normal" way most people would handle the terms RX and TX.

jayAitch256 added a commit to transportkollektiv/feuchtraumabzweigdose-testing that referenced this issue Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant