Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Vault Module]: Refactor vault contract to only manage vault state #51

Open
3 tasks
njokuScript opened this issue Mar 15, 2024 · 0 comments · May be fixed by #60
Open
3 tasks

[Vault Module]: Refactor vault contract to only manage vault state #51

njokuScript opened this issue Mar 15, 2024 · 0 comments · May be fixed by #60
Labels
enhancement New feature or request

Comments

@njokuScript
Copy link
Member

Description

Currently, the vault contract stores users' funds and interacts directly with the token contracts. We want to make sure that the vault is not making any external calls.

  • Vault should only be responsible for managing vault state(balances, collateralization ratio)
  • Introduce Vault IDs when creating vaults
  • Abstract out Liquidation function from Vault module
@njokuScript njokuScript added the enhancement New feature or request label Mar 15, 2024
@ozedd-ee ozedd-ee linked a pull request Jul 11, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Abstract out liquidation function ozedd-ee/Descent-collective-protocol-core
1 participant
@njokuScript