Partially fixed coin pickup #106
Conversation
|
Looking good so far. Just think it will be better to have team specific counts before merging |
|
All that's left is that the UI needs to be updated to reflect team money |
Easier to read over using int values
This Class will be responsible for updating the UI every frame.
There is a bug with the Enum -> Int. This is a band-aid solution until a proper fix is made
|
This solution works as intended albeit there is some bad code in MoneyManager for some reason the conversion between the provided int and enum type |
|
@nisathnasar @Mirlle do you think this is ready for merging or should I try and properly fix the enum issue first |
|
Don't merge it with derangedsenators:main yet. This could be catastrophic. How about we branch off from derangedsenators as a feature 'moneypickup' first, let us cleanse the code a bit and maybe even fix the attack script before considering merging? |
The PR is already linked into main and I don't think that there is anything that conflicts with the attackscript per se. This fix is mostly independent of Attack |
|
How about ParelSync? Should it be in there? |
I think it's good to keep there as we'll probably require it in the future anyway. Although @ashjaimal and @ellimanh may need to remove the |
|
Approval from me, I think peter's already approved it. |
|
✔️ From me... Merging |
Counter is broken; it increases for all clients.
Pickup Script