Meta: scrollIntoViewIfNeeded in options (refined-github#6765)

fregante · web-flow · commit d1b4fce11e9e · 2023-07-08T18:17:11.000Z
diff --git a/source/options.tsx b/source/options.tsx
@@ -210,9 +210,11 @@ function featuresFilterHandler(event: Event): void {
 	}
 }
 
-function focusFirstField(event: DelegateEvent<Event, HTMLDetailsElement>): void {
-	if (event.delegateTarget.open) {
-		const field = select('input, textarea', event.delegateTarget);
+function focusFirstField({delegateTarget: section}: DelegateEvent<Event, HTMLDetailsElement>): void {
+	// @ts-expect-error No Firefox support https://developer.mozilla.org/en-US/docs/Web/API/Element/scrollIntoViewIfNeeded
+	(section.scrollIntoViewIfNeeded ?? section.scrollIntoView).call(section);
+	if (section.open) {
+		const field = select('input, textarea', section);
 		if (field) {
 			field.focus();
 			if (field instanceof HTMLTextAreaElement) {

Original file line number	Diff line number	Diff line change
`@@ -210,9 +210,11 @@ function featuresFilterHandler(event: Event): void {`
`210`	`210`	`}`
`211`	`211`	`}`
`212`	`212`
`213`		`-function focusFirstField(event: DelegateEvent<Event, HTMLDetailsElement>): void {`
`214`		`- if (event.delegateTarget.open) {`
`215`		`- const field = select('input, textarea', event.delegateTarget);`
	`213`	`+function focusFirstField({delegateTarget: section}: DelegateEvent<Event, HTMLDetailsElement>): void {`
	`214`	`+ // @ts-expect-error No Firefox support https://developer.mozilla.org/en-US/docs/Web/API/Element/scrollIntoViewIfNeeded`
	`215`	`+ (section.scrollIntoViewIfNeeded ?? section.scrollIntoView).call(section);`
	`216`	`+ if (section.open) {`
	`217`	`+ const field = select('input, textarea', section);`
`216`	`218`	`if (field) {`
`217`	`219`	`field.focus();`
`218`	`220`	`if (field instanceof HTMLTextAreaElement) {`