Skip to content

Commit dd8eebb

Browse files
Fix: Ubuntu GitHub test action (brafdlog#643)
The `ubuntu-latest` tag was changed to point to Ubuntu 24.04 and has caused regressions. See microsoft/playwright#34251 and electron/electron#42510 for more details. TL;DR: > The solution is to lift the restrictions that Ubuntu 24.04 implements in the AppImages. > ``` > sudo sysctl -w kernel.apparmor_restrict_unprivileged_userns=0 > ``` ## Update The command above fixed the `Process failed to launch` error, but instead produced a `Timeout 30000ms exceeded` error. For now, setting tests to run on ubuntu-22.04 as that seems to work at the moment. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit ## Summary by CodeRabbit - **Chores** - Enhanced the automated testing workflow by updating the operating system to Ubuntu 22.04, improving the reliability of our testing process. <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Co-authored-by: Baruch Odem <[email protected]>
1 parent 3e7c007 commit dd8eebb

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

.github/workflows/tests.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ jobs:
1818
matrix:
1919
os:
2020
# - windows-latest
21-
- ubuntu-latest
21+
- ubuntu-22.04 # TODO: Use latest when https://github.com/electron/electron/issues/42510 is fixed
2222
# - macos-latest
2323

2424
runs-on: ${{ matrix.os }}
@@ -38,7 +38,7 @@ jobs:
3838
# I ran into problems trying to run an electron window in ubuntu due to a missing graphics server.
3939
# That's why this special command for Ubuntu is here
4040
- run: xvfb-run --auto-servernum --server-args="-screen 0 1280x960x24" -- yarn test:e2e
41-
if: matrix.os == 'ubuntu-latest'
41+
if: startsWith(matrix.os, 'ubuntu')
4242

4343
- run: yarn test:e2e
44-
if: matrix.os != 'ubuntu-latest'
44+
if: ${{ !startsWith(matrix.os, 'ubuntu') }}

0 commit comments

Comments
 (0)